From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:16529 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753Ab0LPIy1 (ORCPT ); Thu, 16 Dec 2010 03:54:27 -0500 Message-ID: <4D09D3C0.8030409@codeaurora.org> Date: Thu, 16 Dec 2010 14:24:24 +0530 From: Pavan Kondeti MIME-Version: 1.0 Subject: Re: [RFC 2/5] USB: core: OTG Supplement Revision 2.0 updates References: <1292411654-21382-1-git-send-email-pkondeti@codeaurora.org> <1292411654-21382-3-git-send-email-pkondeti@codeaurora.org> <20101215215324.GC9217@kroah.com> In-Reply-To: <20101215215324.GC9217@kroah.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Greg KH Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org On 12/16/2010 3:23 AM, Greg KH wrote: > On Wed, Dec 15, 2010 at 04:44:11PM +0530, Pavankumar Kondeti wrote: >> --- a/drivers/usb/core/driver.c >> +++ b/drivers/usb/core/driver.c >> @@ -1207,6 +1207,19 @@ static int usb_suspend_both(struct usb_device *udev, pm_message_t msg) >> * and flush any outstanding URBs. >> */ >> } else { >> +#ifdef CONFIG_USB_OTG > > No ifdefs allowed, sorry. > > Please rework this. > I have seen using CONFIG_USB_OTG in core/hub.c and followed the same. But the code I have added does not have to depend on CONFGI_USB_OTG. I will fix this in V2 patch set. Thanks, Pavan -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.