From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:18841 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265Ab0LPIyh (ORCPT ); Thu, 16 Dec 2010 03:54:37 -0500 Message-ID: <4D09D3CA.8060601@codeaurora.org> Date: Thu, 16 Dec 2010 14:24:34 +0530 From: Pavan Kondeti MIME-Version: 1.0 Subject: Re: [RFC 3/5] USB: gadget: OTG supplement revision 2.0 updates References: <1292411654-21382-1-git-send-email-pkondeti@codeaurora.org> <1292411654-21382-4-git-send-email-pkondeti@codeaurora.org> <20101215121800.GP2997@legolas.emea.dhcp.ti.com> In-Reply-To: <20101215121800.GP2997@legolas.emea.dhcp.ti.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: balbi@ti.com Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org On 12/15/2010 5:48 PM, Felipe Balbi wrote: > Hi, > > On Wed, Dec 15, 2010 at 04:44:12PM +0530, Pavankumar Kondeti wrote: >> @@ -1047,9 +1065,10 @@ composite_unbind(struct usb_gadget *gadget) >> kfree(cdev->req->buf); >> usb_ep_free_request(gadget->ep0, cdev->req); >> } >> + device_remove_file(&gadget->dev, &dev_attr_host_request); >> + device_remove_file(&gadget->dev, &dev_attr_suspended); >> kfree(cdev); >> set_gadget_data(gadget, NULL); >> - device_remove_file(&gadget->dev, &dev_attr_suspended); > > this looks like something that shouldn't be part of this patch ?!? > Yeah. I will send another patch for removing suspended sysfs file before freeing the cdev. Thanks, Pavan -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.