From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saravana Kannan Subject: Re: [PATCH] drivers: mmc: msm: remove clock disable in probe Date: Thu, 20 Jan 2011 19:24:05 -0800 Message-ID: <4D38FC55.2030601@codeaurora.org> References: <1295374473-27872-1-git-send-email-dwalker@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:1304 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854Ab1AUDYG (ORCPT ); Thu, 20 Jan 2011 22:24:06 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Vitaly Wool Cc: Daniel Walker , davidb@quicinc.com, linux-arm-msm@vger.kernel.org, Sahitya Tummala , linux-arm-kernel@lists.infradead.org On 01/19/2011 02:50 AM, Vitaly Wool wrote: > Hi, > > On Tue, Jan 18, 2011 at 7:14 PM, Daniel Walker wrote: >> The probe function adds the MMC host which can start accepting request >> immediately. There is an assumption here that no requests happen >> immediatly, but it's not always the case. This assumption can causes >> a BUG() when the clocks are disabled. The fix is to just remove the >> clock disable in the probe function. >> >> Signed-off-by: Daniel Walker > > I can add acked-by and/or tested-by if needed. > > ~Vitaly Nack from me. The fix is incorrect. The clocks are alread refcounted in the clock driver. There should be no need to "leave it on because someone else might access it". Every code that needs the clock should have a clk_enable/disable around it and it would all work fine. -Saravana -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.