From: Trilok Soni <tsoni@codeaurora.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Anirudh Ghayal <aghayal@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
rtc-linux@googlegroups.com, linux-arm-msm@vger.kernel.org
Subject: Re: [RFC v2 PATCH 4/7] input: pmic8058_pwrkey: Add support for power key
Date: Wed, 02 Feb 2011 13:13:23 +0530 [thread overview]
Message-ID: <4D490B1B.2060403@codeaurora.org> (raw)
In-Reply-To: <20110201174911.GA518@core.coreip.homeip.net>
Hi Dmitry,
On 2/1/2011 11:19 PM, Dmitry Torokhov wrote:
> On Tue, Feb 01, 2011 at 07:17:40PM +0530, Anirudh Ghayal wrote:
>> From: Trilok Soni <tsoni@codeaurora.org>
>>
>> Add support for PMIC8058 power key driven over dedicated
>> KYPD_PWR_N pin. It allows the user to specify the amount
>> of time by which the power key reporting can be delayed.
>>
>> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> Signed-off-by: Trilok Soni <tsoni@codeaurora.org>
>> ---
>> Changes from v1:
>> Addressed review comments from Dmitry.
>> Added KEY_SCREENLOCK instead of KEY_END.
>
> ...
>> + input_report_key(pwrkey->pwr, KEY_SCROLLLOCK, 1);
> ...
>> + input_report_key(pwrkey->pwr, KEY_SCREENLOCK, 0);
> ...
>> + input_set_capability(pwr, EV_KEY, KEY_SCROLLLOCK);
>
>
> You are confused about the event you are sending.
My mistake. I will fix this to KEY_SCREENLOCK in v3.
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-02-02 7:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 13:47 [RFC v2 PATCH 0/7] Qualcomm PMIC8058 sub-device drivers Anirudh Ghayal
2011-02-01 13:47 ` [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows and columns Anirudh Ghayal
2011-02-09 8:02 ` Eric Miao
2011-02-10 12:20 ` Trilok Soni
2011-02-10 12:40 ` Eric Miao
2011-02-01 13:47 ` [RFC v2 PATCH 2/7] input: pm8058_keypad: Qualcomm PMIC8058 keypad controller driver Anirudh Ghayal
2011-02-01 13:47 ` [RFC v2 PATCH 3/7] led: pmic8058: Add PMIC8058 leds driver Anirudh Ghayal
2011-02-06 1:47 ` Lars-Peter Clausen
2011-02-01 13:47 ` [RFC v2 PATCH 4/7] input: pmic8058_pwrkey: Add support for power key Anirudh Ghayal
2011-02-01 17:49 ` Dmitry Torokhov
2011-02-02 7:43 ` Trilok Soni [this message]
2011-02-01 13:47 ` [RFC v2 PATCH 5/7] input: pmic8058-othc: Add support for PM8058 based OTHC Anirudh Ghayal
2011-02-01 14:33 ` [rtc-linux] " Mark Brown
2011-02-02 7:51 ` Trilok Soni
2011-02-01 13:47 ` [RFC v2 PATCH 6/7] drivers: rtc: Add support for Qualcomm PMIC8058 RTC Anirudh Ghayal
2011-02-01 13:47 ` [RFC v2 PATCH 7/7] input: misc: Add support for PM8058 based vibrator driver Anirudh Ghayal
2011-02-02 8:33 ` Dmitry Torokhov
2011-02-02 8:53 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D490B1B.2060403@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=aghayal@codeaurora.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).