From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Muckle Subject: Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets Date: Fri, 11 Feb 2011 12:51:54 -0800 Message-ID: <4D55A16A.7030300@codeaurora.org> References: <1297456098-3241-1-git-send-email-stepanm@codeaurora.org> <1297456098-3241-2-git-send-email-stepanm@codeaurora.org> <1297456934.4852.11.camel@m0nster> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:34608 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758096Ab1BKUvz (ORCPT ); Fri, 11 Feb 2011 15:51:55 -0500 In-Reply-To: <1297456934.4852.11.camel@m0nster> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Daniel Walker Cc: Stepan Moskovchenko , davidb@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 02/11/11 12:42, Daniel Walker wrote: >> static struct resource msm_iommu_jpegd_resources[] = { >> { >> - .start = MSM_IOMMU_JPEGD_PHYS, >> - .end = MSM_IOMMU_JPEGD_PHYS + MSM_IOMMU_JPEGD_SIZE - 1, >> + .start = 0x07300000, >> + .end = 0x07300000 + SZ_1M - 1, > > Looks worse .. Just put the macros into a static header file for both. Why bother defining macros for these if they only appear here? I don't think that adds any value or readability - these addresses are clearly the physical area for the msm_iommu_jpegd. It just makes it more annoying to have to look up the values in a separate file if you are wondering what they are. thanks, Steve -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.