From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saravana Kannan Subject: Re: [PATCH] msm: gpiomux: Remove GPIOMUX_VALID and merge config enums Date: Tue, 01 Mar 2011 18:59:19 -0800 Message-ID: <4D6DB287.4000102@codeaurora.org> References: <4D680EEE.1070706@codeaurora.org> <4D689230.7020704@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:18056 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755435Ab1CBC7U (ORCPT ); Tue, 1 Mar 2011 21:59:20 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Dima Zavin , Rohit Vaswani Cc: Russell King - ARM Linux , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan Huntsman , dwalker@fifo99.com, David Brown , linux-arm-kernel On 03/01/2011 06:25 PM, Dima Zavin wrote: > Good point, ptr to anon struct would work. Glad to know the suggestion helped. > I would still very much like to see the helper macros be added though > as it really would be very helpful in keeping the pinmuxing tidy in > the board files. Doing it as a separate patch is fine. > > Other than the addition of helper macros, ack. Rohit, would you mind adding the helper macros that use pointer to anon struct to simplify the GPIO config population in the board files? You can contact me offline if you need any help with it. Thanks, Saravana -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.