From mboxrd@z Thu Jan  1 00:00:00 1970
From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Subject: Re: [Qualcomm PM8921 MFD 1/6] mfd: pm8921: Add PMIC 8921 core driver
Date: Wed, 02 Mar 2011 19:38:24 -0800
Message-ID: <4D6F0D30.1050403@codeaurora.org>
References: <1299104001-5240-1-git-send-email-adharmap@codeaurora.org> <1299104001-5240-2-git-send-email-adharmap@codeaurora.org> <20110302222850.GA32325@opensource.wolfsonmicro.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from wolverine02.qualcomm.com ([199.106.114.251]:14100 "EHLO
	wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756830Ab1CCDiZ (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Wed, 2 Mar 2011 22:38:25 -0500
In-Reply-To: <20110302222850.GA32325@opensource.wolfsonmicro.com>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: davidb@codeaurora.org, "David S. Miller" <davem@davemloft.net>, Andrew Morton <akpm@linux-foundation.org>, Bryan Huntsman <bryanh@codeaurora.org>, Daniel Walker <dwalker@fifo99.com>, David Collins <collinsd@codeaurora.org>, Grant Likely <grant.likely@secretlab.ca>, Greg Kroah-Hartman <gregkh@suse.de>, Joe Perches <joe@perches.com>, Russell King <linux@arm.linux.org.uk>, Samuel Ortiz <sameo@linux.intel.com>, Stepan Moskovchenko <stepanm@codeaurora.org>, Linus Walleij <linux.walleij@sterricsson.com>, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org

Mark Brown wrote:
> On Wed, Mar 02, 2011 at 02:13:16PM -0800, adharmap@codeaurora.org wrote:
> 
>> +config MFD_PM8XXX
>> +	tristate "Support for Qualcomm PM8xxx subdevices"
>> +	help
>> +	  This option enables the usage of various Qualcomm PMIC 8xxx subdevice
>> +	  drivers. This is required in order to use generic PM8xxx subdevice
>> +	  drivers. Selecting with option will result in PM8xxx subdevice
>> +	  drivers being compiled by default.
> 
> As this is selected by the driver it shouldn't have any help text -
> there's no point in users seeing the option since it's useless by
> itself.  If we get enough to make an option useful either a menu or
> dependencies from the individual MFDs would be a better option.

Agree will fix this.
> 
>> +static int __devinit pm8921_add_subdevices(const struct pm8921_platform_data
>> +					   *pdata,
>> +					   struct pm8921 *pmic)
>> +{
>> +	return 0;
>> +}
> 
> This looks suspicious.

True, the next patch fills in this function. Will remove it from here.

> 
>> +static int __init pm8921_init(void)
>> +{
>> +	return platform_driver_register(&pm8921_driver);
>> +}
>> +postcore_initcall(pm8921_init);
> 
> Typically subsys_initcall() has been used.

Yes will change this and others to subsys_initcall()


--
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm 
Innovation Center, Inc. is a member of the Code Aurora Forum.