From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abhijeet Dharmapurikar Subject: Re: [Qualcomm PM8921 MFD 2/6] mfd: pm8xxx: Add irq support Date: Thu, 03 Mar 2011 14:55:00 -0800 Message-ID: <4D701C44.7090506@codeaurora.org> References: <1299104001-5240-1-git-send-email-adharmap@codeaurora.org> <1299104001-5240-3-git-send-email-adharmap@codeaurora.org> <20110302224616.GB32325@opensource.wolfsonmicro.com> <4D6F1B2B.3090706@codeaurora.org> <20110303152242.GB32234@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:36379 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759020Ab1CCWzC (ORCPT ); Thu, 3 Mar 2011 17:55:02 -0500 In-Reply-To: <20110303152242.GB32234@opensource.wolfsonmicro.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Mark Brown Cc: davidb@codeaurora.org, "David S. Miller" , Andrew Morton , Bryan Huntsman , Daniel Walker , David Collins , Grant Likely , Greg Kroah-Hartman , Joe Perches , Russell King , Samuel Ortiz , Stepan Moskovchenko , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Mark Brown wrote: > On Wed, Mar 02, 2011 at 08:38:03PM -0800, Abhijeet Dharmapurikar wrote: >> Mark Brown wrote: > >>> Is it really useful to register a struct device purely for the interrupt >>> controller? I'd have expected this to be core functionality of the >>> device. The fact that you need to store the device at all is a bit odd >>> too as you're using the MFD API. > >> This design is slightly different from other MFD drivers. >> I separated the interrupt from the core because the interrupt >> implementation for different Qualcomm pmics remains the same. On >> 8660 FFA boards for example, we have two pmic chips that have the >> same interrupt subdevice implementation (the number of interrupts >> managed by each is different). I didn't want to duplicate the exact >> code in the core driver - hence a separate interrupt driver. > > Could you deal with this with a library instead? Can you please clarify what a library means here? >> pm8xxxx_read_block > >> Do you still think I should change the name? > > I'd suggest adding an _irq in there. Ok will do. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.