From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Kondeti Subject: Re: [PATCH] USB: Fix trout build failure with ci13xxx_msm gadget Date: Thu, 07 Apr 2011 16:04:21 +0530 Message-ID: <4D9D932D.6000903@codeaurora.org> References: <1296794298-3208-1-git-send-email-pkondeti@codeaurora.org> <20110405125527.GQ30505@legolas.emea.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:25681 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754952Ab1DGKe0 (ORCPT ); Thu, 7 Apr 2011 06:34:26 -0400 In-Reply-To: <20110405125527.GQ30505@legolas.emea.dhcp.ti.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: balbi@ti.com Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org On 4/5/2011 6:25 PM, Felipe Balbi wrote: > On Fri, Feb 04, 2011 at 10:08:18AM +0530, Pavankumar Kondeti wrote: >> This patch fixes the below compilation errors. >> >> CC drivers/usb/gadget/ci13xxx_msm.o >> CC net/mac80211/led.o >> drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event': >> drivers/usb/gadget/ci13xxx_msm.c:42: error: 'USB_AHBBURST' undeclared (first use in this function) >> drivers/usb/gadget/ci13xxx_msm.c:42: error: (Each undeclared identifier is reported only once >> drivers/usb/gadget/ci13xxx_msm.c:42: error: for each function it appears in.) >> drivers/usb/gadget/ci13xxx_msm.c:43: error: 'USB_AHBMODE' undeclared (first use in this function) >> make[4]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1 >> make[3]: *** [drivers/usb/gadget] Error 2 >> >> MSM USB driver is not supported on boards like trout (MSM7201) which >> has an external PHY. >> >> Signed-off-by: Pavankumar Kondeti > > the real fix, though, would be to phase out the PHY to > drivers/usb/otg/blablabla.c. ci13xxx_msm.c shouldn't assume the PHY it's > using. That's wrong. > Agreed. Thanks for pointing this out. I think OTG driver should bail out if the PHY (or SoC) is not supported; which means otg_get_transceiver() returns NULL and gadget/host driver's probe also will fail. -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.