From mboxrd@z Thu Jan 1 00:00:00 1970 From: Murali Nalajala Subject: Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support. Date: Tue, 26 Apr 2011 18:27:35 +0530 Message-ID: <4DB6C13F.2020402@codeaurora.org> References: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org> <4DABE8FE.5040300@parrot.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:27690 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754523Ab1DZM5k (ORCPT ); Tue, 26 Apr 2011 08:57:40 -0400 In-Reply-To: <4DABE8FE.5040300@parrot.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Matthieu CASTET Cc: "dwmw2@infradead.org" , "linux-arm-msm@vger.kernel.org" , Dima Zavin , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Brian Swetland , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" On 4/18/2011 1:02 PM, Matthieu CASTET wrote: > Hi, > > Murali Nalajala a =C3=A9crit : >> Add initial msm nand driver support for Qualcomm MSM platforms. >> This driver is capable of handling both 2k and 4k page support >> nand devices. >> >> This driver was originally developed by Arve Hj=C3=B8nnev=C3=A5g at = google. >> Its source is available at >> http://android.git.kernel.org/?p=3Dkernel/msm.git under >> android-msm-2.6.35 branch. >> >> CC: Dima Zavin >> CC: Brian Swetland >> CC: Arve Hj=C3=B8nnev=C3=A5g >> Signed-off-by: Murali Nalajala >> --- >> Changes in V2 >> * Turn most of the pr_info() calls into pr_debug(). >> >> drivers/mtd/devices/Kconfig | 11 + >> drivers/mtd/devices/Makefile | 1 + >> drivers/mtd/devices/msm_nand.c | 1597 ++++++++++++++++++++++++++++= ++++++++++++ >> drivers/mtd/devices/msm_nand.h | 77 ++ >> 4 files changed, 1686 insertions(+), 0 deletions(-) >> create mode 100644 drivers/mtd/devices/msm_nand.c >> create mode 100644 drivers/mtd/devices/msm_nand.h >> > > For the record, I am not sure it is a great idea to make nand drivers > independent of the nand layer. > By doing that you could change the expected behavior, and introduce b= ug > difficult to debug. > > Why do you need that ? Nand drivers can override callbacks of nand fr= amework. > > Maybe because the nand layer call the driver page per page, and you = want to > work with more than one page. But in this case you can extend nand la= yer. > > Or does your controller don't allow sending raw command ? > And in that case all the nand logic is in the nand controller ? Our controller doesn't allow sending RAW commands to the flash. All=20 these commands are abstracted by the controller logic. Please refer the= =20 msm_nand.h file where you will find the commands which are different=20 from the actual NAND device commands. eg: To send read/write data command to the device we configure the=20 controller with page address & controller specific command. Then the=20 controller itself takes care of generating the internal h/w signals=20 required by the flash and it polls for the R/B signal & wait states are= =20 internally controlled by the h/w. > > Matthieu Thanks, Murali N --=20 Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora For= um.