linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavan Kondeti <pkondeti@codeaurora.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: greg@kroah.com, linux-usb@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Anji jonnala <anjir@codeaurora.org>
Subject: Re: [PATCH 1/5] USB: gadget: Use Zero Interrupt Threshold Control for ci13xxx_msm
Date: Fri, 29 Apr 2011 10:46:59 +0530	[thread overview]
Message-ID: <4DBA49CB.8040301@codeaurora.org> (raw)
In-Reply-To: <4DB95B09.9000207@ru.mvista.com>

Hi Sergei

Thanks for review.

On 4/28/2011 5:48 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 28-04-2011 12:01, Pavankumar Kondeti wrote:
> 
>> From: Anji jonnala <anjir@codeaurora.org>
> 
<snip>
>> +	/*
>> +	 * ITC (Interrupt Threshold Control) field is to set the maximum
>> +	 * rate at which the device controller will issue interrupts.
>> +	 * The maximum interrupt interval measured in micro frames.
>> +	 * Valid values are 0, 1, 2, 4, 8, 16, 32, 64. The default value is
>> +	 * 8 micro frames. If CPU can handle interrupts at faster rate, ITC
>> +	 * can be set to lesser value to gain performance.
>> +	 */
>> +	if (udc->udc_driver->flags && CI13XXX_ZERO_ITC)
> 
>     I think you meant bitwise AND (&) here.

Yes. I will fix it and resend the patch.

Thanks,
Pavan

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2011-04-29  5:17 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28  8:01 [PATCH 1/5] USB: gadget: Use Zero Interrupt Threshold Control for ci13xxx_msm Pavankumar Kondeti
2011-04-28  8:01 ` [PATCH 2/5] USB: OTG: vote for dayatona fabric clock Pavankumar Kondeti
2011-04-28  8:01 ` [PATCH 3/5] USB: OTG: msm: Implement charger detection Pavankumar Kondeti
2011-04-28  8:01 ` [PATCH 4/5] USB: OTG: msm: Configure PHY Analog and Digital voltage domains Pavankumar Kondeti
2011-04-29 10:14   ` Sergei Shtylyov
2011-05-02  6:03     ` Pavan Kondeti
2011-04-28  8:01 ` [PATCH 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960 Pavankumar Kondeti
2011-04-28 14:49   ` Sergei Shtylyov
2011-04-29  5:20     ` Pavan Kondeti
2011-04-28 12:18 ` [PATCH 1/5] USB: gadget: Use Zero Interrupt Threshold Control for ci13xxx_msm Sergei Shtylyov
2011-04-29  5:16   ` Pavan Kondeti [this message]
2011-04-29  5:22 ` Pavankumar Kondeti
2011-04-29  5:22   ` [PATCH 2/5] USB: OTG: vote for dayatona fabric clock Pavankumar Kondeti
     [not found]   ` <1304054532-3523-1-git-send-email-pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-04-29  5:22     ` [PATCH 3/5] USB: OTG: msm: Implement charger detection Pavankumar Kondeti
2011-04-29  5:22     ` [PATCH 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960 Pavankumar Kondeti
2011-04-29  5:22   ` [PATCH 4/5] USB: OTG: msm: Configure PHY Analog and Digital voltage domains Pavankumar Kondeti
2011-05-02  6:36 ` [PATCH V2 0/5] USB Charging, PHY init and suspend support for MSM8960 Pavankumar Kondeti
2011-05-02  6:36   ` [PATCH V2 1/5] USB: gadget: Use Zero Interrupt Threshold Control for ci13xxx_msm Pavankumar Kondeti
2011-05-02  6:36   ` [PATCH V2 2/5] USB: OTG: vote for dayatona fabric clock Pavankumar Kondeti
2011-05-02  6:36   ` [PATCH V2 3/5] USB: OTG: msm: Implement charger detection Pavankumar Kondeti
     [not found]   ` <1304318192-24374-1-git-send-email-pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-02  6:36     ` [PATCH V2 4/5] USB: OTG: msm: Configure PHY Analog and Digital voltage domains Pavankumar Kondeti
2011-05-02  6:36   ` [PATCH V2 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960 Pavankumar Kondeti
2011-05-02 12:22     ` Sergei Shtylyov
2011-05-03  5:01       ` Pavan Kondeti
     [not found] ` <1303977693-18389-1-git-send-email-pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-02  9:58   ` [PATCH V3 0/5] USB Charging, PHY init and " Pavankumar Kondeti
     [not found]     ` <1304330325-21982-1-git-send-email-pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-02  9:58       ` [PATCH V3 1/5] USB: gadget: Use Zero Interrupt Threshold Control for ci13xxx_msm Pavankumar Kondeti
2011-05-02  9:58       ` [PATCH V3 2/5] USB: OTG: msm: vote for dayatona fabric clock Pavankumar Kondeti
2011-05-02  9:58       ` [PATCH V3 3/5] USB: OTG: msm: Implement charger detection Pavankumar Kondeti
2011-05-02  9:58     ` [PATCH V3 4/5] USB: OTG: msm: Configure PHY Analog and Digital voltage domains Pavankumar Kondeti
2011-05-02  9:58     ` [PATCH V3 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960 Pavankumar Kondeti
2011-05-03  5:13 ` [PATCH V4 0/5] USB Charging, PHY init and " Pavankumar Kondeti
     [not found]   ` <1304399633-16120-1-git-send-email-pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-03  5:13     ` [PATCH V4 1/5] USB: gadget: Use Zero Interrupt Threshold Control for ci13xxx_msm Pavankumar Kondeti
2011-05-03  5:13   ` [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock Pavankumar Kondeti
     [not found]     ` <1304399633-16120-3-git-send-email-pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-03 11:14       ` Sergei Shtylyov
2011-05-03 12:29         ` Pavan Kondeti
2011-05-03 17:15           ` Greg KH
2011-05-04  4:48             ` Pavan Kondeti
2011-05-03  5:13   ` [PATCH V4 3/5] USB: OTG: msm: Implement charger detection Pavankumar Kondeti
2011-05-03  5:13   ` [PATCH V4 4/5] USB: OTG: msm: Configure PHY Analog and Digital voltage domains Pavankumar Kondeti
2011-05-03  5:13   ` [PATCH V4 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960 Pavankumar Kondeti
2011-05-04  4:49 ` [PATCH V5 0/4] USB Charging, PHY init and " Pavankumar Kondeti
2011-05-04  4:49   ` [PATCH V5 1/4] USB: OTG: msm: vote for dayatona fabric clock Pavankumar Kondeti
2011-05-04  4:49   ` [PATCH V5 2/4] USB: OTG: msm: Implement charger detection Pavankumar Kondeti
     [not found]   ` <1304484589-17186-1-git-send-email-pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-04  4:49     ` [PATCH V5 3/4] USB: OTG: msm: Configure PHY Analog and Digital voltage domains Pavankumar Kondeti
2011-05-04  4:49     ` [PATCH V5 4/4] USB: OTG: msm: Add PHY suspend support for MSM8960 Pavankumar Kondeti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBA49CB.8040301@codeaurora.org \
    --to=pkondeti@codeaurora.org \
    --cc=anjir@codeaurora.org \
    --cc=greg@kroah.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).