From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Kondeti Subject: Re: [PATCH 1/5] USB: gadget: Use Zero Interrupt Threshold Control for ci13xxx_msm Date: Fri, 29 Apr 2011 10:46:59 +0530 Message-ID: <4DBA49CB.8040301@codeaurora.org> References: <1303977693-18389-1-git-send-email-pkondeti@codeaurora.org> <4DB95B09.9000207@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:22905 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391Ab1D2FRE (ORCPT ); Fri, 29 Apr 2011 01:17:04 -0400 In-Reply-To: <4DB95B09.9000207@ru.mvista.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sergei Shtylyov Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, Anji jonnala Hi Sergei Thanks for review. On 4/28/2011 5:48 PM, Sergei Shtylyov wrote: > Hello. > > On 28-04-2011 12:01, Pavankumar Kondeti wrote: > >> From: Anji jonnala > >> + /* >> + * ITC (Interrupt Threshold Control) field is to set the maximum >> + * rate at which the device controller will issue interrupts. >> + * The maximum interrupt interval measured in micro frames. >> + * Valid values are 0, 1, 2, 4, 8, 16, 32, 64. The default value is >> + * 8 micro frames. If CPU can handle interrupts at faster rate, ITC >> + * can be set to lesser value to gain performance. >> + */ >> + if (udc->udc_driver->flags && CI13XXX_ZERO_ITC) > > I think you meant bitwise AND (&) here. Yes. I will fix it and resend the patch. Thanks, Pavan -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.