From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Kondeti Subject: Re: [PATCH 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960 Date: Fri, 29 Apr 2011 10:50:08 +0530 Message-ID: <4DBA4A88.7070204@codeaurora.org> References: <1303977693-18389-1-git-send-email-pkondeti@codeaurora.org> <1303977693-18389-5-git-send-email-pkondeti@codeaurora.org> <4DB97E89.9010206@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:58827 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104Ab1D2FUL (ORCPT ); Fri, 29 Apr 2011 01:20:11 -0400 In-Reply-To: <4DB97E89.9010206@ru.mvista.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sergei Shtylyov Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org Hi Sergei Thanks for review. On 4/28/2011 8:19 PM, Sergei Shtylyov wrote: > Hello. > > Pavankumar Kondeti wrote: > >> Signed-off-by: Pavankumar Kondeti > [...] > >> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c >> index 425418d..fe040a2 100644 >> --- a/drivers/usb/otg/msm_otg.c >> +++ b/drivers/usb/otg/msm_otg.c >> @@ -167,6 +167,32 @@ put_3p3: >> return rc; >> } >> >> +#ifdef CONFIG_PM_SLEEP >> +static int usb_phy_susp_dig_vol = 500000; > > What's the point of making this variable? It doesn't seem to be changed > anywhere... > Correct. I will change it to a macro. >> @@ -489,6 +516,10 @@ static int msm_otg_suspend(struct msm_otg *motg) >> */ >> writel(readl(USB_USBCMD) | ASYNC_INTR_CTRL | ULPI_STP_CTRL, USB_USBCMD); >> >> + if (motg->pdata->phy_type == SNPS_28NM_INTEGRATED_PHY && >> + motg->pdata->phy_type == OTG_PMIC_CONTROL) > > This is never true, I guess. Did you mean || ISO &&? > :-( It should be if (motg->pdata->phy_type == SNPS_28NM_INTEGRATED_PHY && motg->pdata->otg_control == OTG_PMIC_CONTROL) ^^^^^^^^^^^ Thanks, Pavan -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.