From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Kondeti <pkondeti@codeaurora.org>
Subject: Re: [PATCH V2 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960
Date: Tue, 03 May 2011 10:31:50 +0530
Message-ID: <4DBF8C3E.7030703@codeaurora.org>
References: <1303977693-18389-1-git-send-email-pkondeti@codeaurora.org> <1304318192-24374-1-git-send-email-pkondeti@codeaurora.org> <1304318192-24374-6-git-send-email-pkondeti@codeaurora.org> <4DBEA215.5080806@ru.mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from wolverine02.qualcomm.com ([199.106.114.251]:54374 "EHLO
	wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750973Ab1ECFB5 (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Tue, 3 May 2011 01:01:57 -0400
In-Reply-To: <4DBEA215.5080806@ru.mvista.com>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, davidb@codeaurora.org

On 5/2/2011 5:52 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 02-05-2011 10:36, Pavankumar Kondeti wrote:
> 
>> Signed-off-by: Pavankumar Kondeti<pkondeti@codeaurora.org>
> [...]
> 
>> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
>> index 66a1b7c..52853fd 100644
>> --- a/drivers/usb/otg/msm_otg.c
>> +++ b/drivers/usb/otg/msm_otg.c
>> @@ -163,6 +163,32 @@ put_3p3:
>>   	return rc;
>>   }
>>
>> +#ifdef CONFIG_PM_SLEEP
>> +#define USB_PHY_SUSP_DIG_VOL  500000
>> +static int msm_hsusb_config_vddcx(int high)
>> +{
>> +	int max_vol = USB_PHY_VDD_DIG_VOL_MAX;
>> +	int min_vol;
>> +	int ret;
>> +
>> +	if (high)
>> +		min_vol = USB_PHY_VDD_DIG_VOL_MIN;
>> +	else
>> +		min_vol = USB_PHY_SUSP_DIG_VOL;
>> +
>> +	ret = regulator_set_voltage(hsusb_vddcx, min_vol, max_vol);
>> +	if (ret) {
>> +		pr_err("%s: unable to set the voltage for regulator"
> 
>     You missed space after "regulator"...

Thanks for pointing this out. The other patch (USB: OTG: msm: Configure
PHY Analog and Digital voltage domains) also has missed spaces. I will
fix it in next patch set.

> 
>> +			"HSUSB_VDDCX\n", __func__);
>> +		return ret;
>> +	}
>> +
> [...]
> 
> WBR, Sergei

Thanks,
Pavan
-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.