Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock

[Pavan Kondeti <pkondeti@codeaurora.org>]

Hi Sergei,

On 5/3/2011 4:44 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 03-05-2011 9:13, Pavankumar Kondeti wrote:
> 
>> From: Anji jonnala <anjir@codeaurora.org>
> 
>> HSUSB core clock is derived from daytona fabric clock and for
>> HSUSB operational require minimum core clock at 55MHz. Since, HSUSB
>> cannot tolerate daytona fabric clock change in the middle of HSUSB
>> operational, vote for maximum Daytona fabric clock
>> while usb is operational
> 
>> Signed-off-by: Anji jonnala<anjir@codeaurora.org>
>> Signed-off-by: Pavankumar Kondeti<pkondeti@codeaurora.org>
> [...]
> 
>> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
>> index 2965986..cfbb606 100644
>> --- a/drivers/usb/otg/msm_otg.c
>> +++ b/drivers/usb/otg/msm_otg.c
> [...]
>> @@ -954,7 +979,11 @@ free_regs:
>>   put_core_clk:
>>   	if (motg->core_clk)
>>   		clk_put(motg->core_clk);
>> -	clk_put(motg->pclk);
> 
>     Is it really correct to remove this line?
> 
No. It is not correct. I will fix it in next version.

>> +put_pclk_src:
>> +	if (!IS_ERR(motg->pclk_src)) {
>> +		clk_disable(motg->pclk_src);
>> +		clk_put(motg->pclk_src);
>> +	}
>>   put_clk:
>>   	clk_put(motg->clk);
>>   put_phy_reset_clk:
> 
> WBR, Sergei


-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.