Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock

[Pavan Kondeti <pkondeti@codeaurora.org>]

Hi Greg,

On 5/3/2011 10:45 PM, Greg KH wrote:
> On Tue, May 03, 2011 at 05:59:37PM +0530, Pavan Kondeti wrote:
>> Hi Sergei,
>>
>> On 5/3/2011 4:44 PM, Sergei Shtylyov wrote:
>>> Hello.
>>>
>>> On 03-05-2011 9:13, Pavankumar Kondeti wrote:
>>>
>>>> From: Anji jonnala <anjir@codeaurora.org>
>>>
>>>> HSUSB core clock is derived from daytona fabric clock and for
>>>> HSUSB operational require minimum core clock at 55MHz. Since, HSUSB
>>>> cannot tolerate daytona fabric clock change in the middle of HSUSB
>>>> operational, vote for maximum Daytona fabric clock
>>>> while usb is operational
>>>
>>>> Signed-off-by: Anji jonnala<anjir@codeaurora.org>
>>>> Signed-off-by: Pavankumar Kondeti<pkondeti@codeaurora.org>
>>> [...]
>>>
>>>> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
>>>> index 2965986..cfbb606 100644
>>>> --- a/drivers/usb/otg/msm_otg.c
>>>> +++ b/drivers/usb/otg/msm_otg.c
>>> [...]
>>>> @@ -954,7 +979,11 @@ free_regs:
>>>>   put_core_clk:
>>>>   	if (motg->core_clk)
>>>>   		clk_put(motg->core_clk);
>>>> -	clk_put(motg->pclk);
>>>
>>>     Is it really correct to remove this line?
>>>
>> No. It is not correct. I will fix it in next version.
> 
> Next version?
>

I meant next patch set version. Again sorry for the confusion.

> Ok, I'll drop all of these then from my queue.  Please resend when you
> have something working properly.
> 
I have tested the patches well. The driver probe() never failed in my
testing. So could not found this BUG(). I am resending the patch series now.

Thanks,
Pavan

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.