From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Kondeti Subject: Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock Date: Wed, 04 May 2011 10:18:46 +0530 Message-ID: <4DC0DAAE.8000405@codeaurora.org> References: <1303977693-18389-1-git-send-email-pkondeti@codeaurora.org> <1304399633-16120-1-git-send-email-pkondeti@codeaurora.org> <1304399633-16120-3-git-send-email-pkondeti@codeaurora.org> <4DBFE39A.4010804@ru.mvista.com> <4DBFF531.1030208@codeaurora.org> <20110503171539.GA5969@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:56165 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122Ab1EDEsw (ORCPT ); Wed, 4 May 2011 00:48:52 -0400 In-Reply-To: <20110503171539.GA5969@kroah.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Greg KH Cc: Sergei Shtylyov , linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, davidb@codeaurora.org, Anji jonnala Hi Greg, On 5/3/2011 10:45 PM, Greg KH wrote: > On Tue, May 03, 2011 at 05:59:37PM +0530, Pavan Kondeti wrote: >> Hi Sergei, >> >> On 5/3/2011 4:44 PM, Sergei Shtylyov wrote: >>> Hello. >>> >>> On 03-05-2011 9:13, Pavankumar Kondeti wrote: >>> >>>> From: Anji jonnala >>> >>>> HSUSB core clock is derived from daytona fabric clock and for >>>> HSUSB operational require minimum core clock at 55MHz. Since, HSUSB >>>> cannot tolerate daytona fabric clock change in the middle of HSUSB >>>> operational, vote for maximum Daytona fabric clock >>>> while usb is operational >>> >>>> Signed-off-by: Anji jonnala >>>> Signed-off-by: Pavankumar Kondeti >>> [...] >>> >>>> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c >>>> index 2965986..cfbb606 100644 >>>> --- a/drivers/usb/otg/msm_otg.c >>>> +++ b/drivers/usb/otg/msm_otg.c >>> [...] >>>> @@ -954,7 +979,11 @@ free_regs: >>>> put_core_clk: >>>> if (motg->core_clk) >>>> clk_put(motg->core_clk); >>>> - clk_put(motg->pclk); >>> >>> Is it really correct to remove this line? >>> >> No. It is not correct. I will fix it in next version. > > Next version? > I meant next patch set version. Again sorry for the confusion. > Ok, I'll drop all of these then from my queue. Please resend when you > have something working properly. > I have tested the patches well. The driver probe() never failed in my testing. So could not found this BUG(). I am resending the patch series now. Thanks, Pavan -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.