From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA958C6FA8A for ; Mon, 12 Sep 2022 08:52:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230248AbiILIwm (ORCPT ); Mon, 12 Sep 2022 04:52:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbiILIwl (ORCPT ); Mon, 12 Sep 2022 04:52:41 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F5CA2AE28; Mon, 12 Sep 2022 01:52:40 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8BB0C6601D9A; Mon, 12 Sep 2022 09:52:37 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1662972758; bh=7f8rv5NrDbI8FzOJIfOFLtaF6m6zncvjLeOxNvrNntY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Q4m95uyrF2e5NQf3rgUNndX1tSWmGtbnIfqaD7/3Dnkw9R3I9OBHTiT6frONenwqK CM0OJu2Idh9ftssB+g6yY0gX8NakpR3r/tt2HINd3QjsZm3XHYgd1aShlmkE1RRQT2 Ckfy+HXGYpalVO+apg7X1iBvdVGkk4XTZ1FPuQ8ypW4FYNOhL1CDLg20AaNp83yMJa NyDZzmMGWI8VRMyTwFsjww/hyKe14mFzgHjZDrcUTeXAd1VW+f8srUWOGLmtaY1jxE 60boN+crRAl3ezHnThu6NlIpC4BkFF1RHtRjrq0yqJHmTEhoHDaxPsu5lno13Uxbbd Y6jGvMRLwSqzQ== Message-ID: <4a4f2ea4-eb90-14ce-267d-89cc3034feeb@collabora.com> Date: Mon, 12 Sep 2022 10:52:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [RFC PATCH 05/10] thermal/drivers/tsens: drop msm8976-specific defines To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org References: <20220910124701.4060321-1-dmitry.baryshkov@linaro.org> <20220910124701.4060321-6-dmitry.baryshkov@linaro.org> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <20220910124701.4060321-6-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Il 10/09/22 14:46, Dmitry Baryshkov ha scritto: > Drop msm8976-specific defines, which duplicate generic ones. > > Cc: Konrad Dybcio > Cc: AngeloGioacchino Del Regno > Signed-off-by: Dmitry Baryshkov The duplication is useless indeed... However, should you add a Fixes tag here? 0e580290170d ("thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976") Anyway, for the code: Reviewed-by: AngeloGioacchino Del Regno Cheers, Angelo