From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE83C433EF for ; Thu, 23 Sep 2021 10:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B860F6103D for ; Thu, 23 Sep 2021 10:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240331AbhIWKPU (ORCPT ); Thu, 23 Sep 2021 06:15:20 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:40730 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240337AbhIWKPT (ORCPT ); Thu, 23 Sep 2021 06:15:19 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632392028; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=AOhxSdZwfyMsdUznn5MrHD1bvqUT9drqSO1Hx/Gl3ro=; b=UE9jB+o83PnKJKHoW1IaDFh//NTMD64x8TXh6HoCCxEhFdh0A1EfU/PEqcpruj4yTqHlE4Je 8M2Ss80+yB7lk0mS0hTR57tu/ly/pFmUO8MIM7QRNR/07lHDofaJBXeFNBEgzkALKg+JokV/ 9zAxc6h8RiXeRQNalH29/8ADlFA= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 614c53438b04ef85893b08b4 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 23 Sep 2021 10:13:23 GMT Sender: rajpat=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E8374C43618; Thu, 23 Sep 2021 10:13:22 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rajpat) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3B1D4C4338F; Thu, 23 Sep 2021 10:13:22 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Sep 2021 15:43:22 +0530 From: rajpat@codeaurora.org To: Doug Anderson Cc: Stephen Boyd , Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rajendra Nayak , Sai Prakash Ranjan , msavaliy@qti.qualcomm.com, satya priya , Matthias Kaehlcke , Roja Rani Yarubandi Subject: Re: [PATCH V9 4/8] arm64: dts: sc7280: Add QUPv3 wrapper_0 nodes In-Reply-To: References: <21d14dd0bfa945ee617ed4b86b4495ee@codeaurora.org> Message-ID: <4ac4e619e5269efc04c9160710d506de@codeaurora.org> X-Sender: rajpat@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-09-22 20:24, Doug Anderson wrote: > Hi, > > On Wed, Sep 22, 2021 at 5:31 AM wrote: >> >> >> + spi0: spi@980000 { >> >> + compatible = "qcom,geni-spi"; >> >> + reg = <0 0x00980000 0 0x4000>; >> >> + clocks = <&gcc >> >> GCC_QUPV3_WRAP0_S0_CLK>; >> >> + clock-names = "se"; >> >> + pinctrl-names = "default"; >> >> + pinctrl-0 = <&qup_spi0_data_clk>, >> >> <&qup_spi0_cs>, <&qup_spi0_cs_gpio>; >> > >> > This should only have qup_spi0_data_clk and qup_spi0_cs, not >> > qup_spi0_cs_gpio. Both qup controlled and gpio controlled options are >> > provided in case a board wants to use the qup version of chipselect, >> > but >> > having them both used by default leads to conflicts and confusion. This >> > same comment applies to all spi pinctrl properties in this file. Please >> > keep the cs_gpio variants though so that boards can use them if they >> > want. They will be unused, but that's OK. >> >> Okay. Shall we remove only "<&qup_spiN_cs_gpio>" in each SPI node? > > Right. So for this one: > > pinctrl-0 = <&qup_spi0_data_clk>, <&qup_spi0_cs>; > > -Doug Okay.