From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6680F190682 for ; Fri, 7 Jun 2024 12:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717764225; cv=none; b=pQd3l1WPC5CrNomGUFrJCj1yi4HOfOK0nWMv+V2vLB2OCMNJNUuKnj6vFf15a0Q5CCToSAeUPrBr9G2qPwJm47cOYTPXCUmooiZ0VCTDwzJCl4jv2sF4NfZrphyt0rb7WcAI4ZOp2S3EqW2yg2+w84H5DtWwnldDjAVqzbGJlCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717764225; c=relaxed/simple; bh=DKpJMqjH6UtbwvLCWvGMlCN5FOTyMqaNnYZVGLw5QrA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BXDxyt9dAihwKYTS82hodGhUTyz/plRa4bSrOkVAWs2suVOOOFAbMWdYfEkJdokZldh3W1qNAwN8KKCfjwRA4FwEJicrbS6c2QDwBMXMOTIoiPVMwgTj5wtK4ma8kyYo6yUroSEZxoDj85fVPpnlw+8r3KjQ9rZ//ULFIajaE8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VUoqhp0a; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VUoqhp0a" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a69607c6ccaso243099366b.2 for ; Fri, 07 Jun 2024 05:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717764222; x=1718369022; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vPT1BhYTFvN8bBYnTvz9S5wwBpb/ePs438aoM49eAiY=; b=VUoqhp0aC25mHhp92CVulstkQ6dKtmZKzGGX6ez4EW8U3UDdTwgNYtahE9OzPLRuIf cPUvtStd3o8qeBfNk8CHY7OIh6i2RyJzHo7VLmdQh0F2S4r4h/LcRa5IqQ1c9ovQoCDb /AyLrwnnsmyB60J93dmXerb5TUx5q49Mw5LW9c+6voXBXiKanHUCoa7Li2MFxKuonigC TKMuyCmNDgoa49EQv87l3zGqBFaJxJLfEiSHiFl02J2ROZdtYTlGFfcYHRRld7/EaZ3w NqkS/6jXrY5z2S+5c0CRLz98gxJIJo1GoPlKNshT2nPwh/rnCJzSkCVKavpkpahCyxUY 9LOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717764222; x=1718369022; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vPT1BhYTFvN8bBYnTvz9S5wwBpb/ePs438aoM49eAiY=; b=HtCjK4yB6MdvLSlJoYmVpV5fsAPU8GGAjN7DNyjZAWZVRrmEvd4bVo9QTO3E0xbJkw LLP/DzVtUyKwibik96/wR1bKLXmosvZ6WzkLc6wMrGk87llW+vrEW94x6F8T7iWofk4e pyGQpoRG0n4hGuK54R7CwS8qrqFyLQ/b4npth4yE35/02gG+V+vpfmOL+bCz7X6Vk0qA 35slj0Tevb8iHVsO9NUUajO119x+VVeZCEszUqTLPW9Guet/0rilKiNSYKUZsFCd6d61 EjyWDmAtpz54pCb6i28o8pFxQLV8GkSVsT8U5r8uNHgqcHT1qtxBA6TODJNerh5sBkTO gipg== X-Forwarded-Encrypted: i=1; AJvYcCXgfqaY8tGWOjbaYvq5pTjElERkInZCkZZVnB/FXJmFruh3Gc9e7ehr22pcWfwdELxVGLJYlgoQB7IUR/eiQUwDnstScMEoqk0aomlNeQ== X-Gm-Message-State: AOJu0YzZyBLNyaAoElVvlHLWpul3aBsYnypARoxhh5KTYc3EfkoesrjW edBeESKxVosfmNeFjd6C+BXX5Ytl/Eqa42y+a0q50BCsCFqd7Dk/seyzSw6in7A= X-Google-Smtp-Source: AGHT+IHtfKE/HfIALfDQFvlb45n2TB4/rMk87fD9LzhzyTIhts6WW2zXNjchATbkzKvluIQutnGQOg== X-Received: by 2002:a17:907:31c4:b0:a6a:617a:5da1 with SMTP id a640c23a62f3a-a6cd675ce0fmr184414366b.27.1717764221743; Fri, 07 Jun 2024 05:43:41 -0700 (PDT) Received: from ?IPV6:2a02:8109:aa0d:be00::8090? ([2a02:8109:aa0d:be00::8090]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c8070f879sm243927166b.173.2024.06.07.05.43.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 05:43:41 -0700 (PDT) Message-ID: <4ac692bf-55d5-4a66-acda-72353d817de4@linaro.org> Date: Fri, 7 Jun 2024 14:43:40 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/11] misc: fastrpc: Avoid updating PD type for capability request To: Ekansh Gupta , srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, stable References: <20240606165939.12950-1-quic_ekangupt@quicinc.com> <20240606165939.12950-5-quic_ekangupt@quicinc.com> Content-Language: en-US From: Caleb Connolly In-Reply-To: <20240606165939.12950-5-quic_ekangupt@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/06/2024 18:59, Ekansh Gupta wrote: > When user is requesting for DSP capability, the process pd type is > getting updated to USER_PD which is incorrect as DSP will assume the > process which is making the request is a user PD and this will never > get updated back to the original value. The actual PD type should not > be updated for capability request and it should be serviced by the > respective PD on DSP side. Adding changes to avoid process PD type > modification. > > Fixes: 6c16fd8bdd40 ("misc: fastrpc: Add support to get DSP capabilities") > Cc: stable > Signed-off-by: Ekansh Gupta Reviewed-by: Caleb Connolly > --- > drivers/misc/fastrpc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index f64781c3012f..abdd35b7c3ad 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -1703,7 +1703,6 @@ static int fastrpc_get_info_from_dsp(struct fastrpc_user *fl, uint32_t *dsp_attr > args[1].ptr = (u64)(uintptr_t)&dsp_attr_buf[1]; > args[1].length = dsp_attr_buf_len * sizeof(u32); > args[1].fd = -1; > - fl->pd = USER_PD; > > return fastrpc_internal_invoke(fl, true, FASTRPC_DSP_UTILITIES_HANDLE, > FASTRPC_SCALARS(0, 1, 1), args); -- // Caleb (they/them)