Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

Greg Kroah-Hartman
2020-06-10T13:37:27Z

On Wed, Jun 10, 2020 at 04:29:27PM +0300, Stanimir Varbanov wrote:
>
>
> On 6/9/20 2:14 PM, Greg Kroah-Hartman wrote:
> > On Tue, Jun 09, 2020 at 01:46:03PM +0300, Stanimir Varbanov wrote:
> >> Here we introduce few debug macros with levels (low, medium and
> >> high) and debug macro for firmware. Enabling the particular level
> >> will be done by dynamic debug with levels.
> >>
> >> For example to enable debug messages with low level:
> >> echo 'module venus_dec level 0x01 +p' > debugfs/dynamic_debug/control
> >>
> >> If you want to enable all levels:
> >> echo 'module venus_dec level 0x07 +p' > debugfs/dynamic_debug/control
> >>
> >> All the features which dynamic debugging provide are preserved.
> >>
> >> And finaly all dev_dbg are translated to VDBGX with appropriate
> >> debug levels.
> >>
> >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> >> ---
> >> drivers/media/platform/qcom/venus/core.h | 5 ++
> >> drivers/media/platform/qcom/venus/helpers.c | 2 +-
> >> drivers/media/platform/qcom/venus/hfi_msgs.c | 30 ++++-----
> >> drivers/media/platform/qcom/venus/hfi_venus.c | 20 ++++--
> >> .../media/platform/qcom/venus/pm_helpers.c | 3 +-
> >> drivers/media/platform/qcom/venus/vdec.c | 63 +++++++++++++++++--
> >> drivers/media/platform/qcom/venus/venc.c | 4 ++
> >> 7 files changed, 96 insertions(+), 31 deletions(-)
> >>
> >> diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
> >> index b48782f9aa95..63eabf5ff96d 100644
> >> --- a/drivers/media/platform/qcom/venus/core.h
> >> +++ b/drivers/media/platform/qcom/venus/core.h
> >> @@ -15,6 +15,11 @@
> >> #include "dbgfs.h"
> >> #include "hfi.h"
> >>
> >> +#define VDBGL(fmt, args...) pr_debug_level(0x01, fmt, ##args)
> >> +#define VDBGM(fmt, args...) pr_debug_level(0x02, fmt, ##args)
> >> +#define VDBGH(fmt, args...) pr_debug_level(0x04, fmt, ##args)
> >> +#define VDBGFW(fmt, args...) pr_debug_level(0x08, fmt, ##args)
> >> +
> >> #define VIDC_CLKS_NUM_MAX 4
> >> #define VIDC_VCODEC_CLKS_NUM_MAX 2
> >> #define VIDC_PMDOMAINS_NUM_MAX 3
> >> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> >> index 0143af7822b2..115a9a2af1d6 100644
> >> --- a/drivers/media/platform/qcom/venus/helpers.c
> >> +++ b/drivers/media/platform/qcom/venus/helpers.c
> >> @@ -396,7 +396,7 @@ put_ts_metadata(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf)
> >> }
> >>
> >> if (slot == -1) {
> >> - dev_dbg(inst->core->dev, "%s: no free slot\n", __func__);
> >> + VDBGH("no free slot for timestamp\n");
> >
> > So you just lost the information that dev_dbg() gave you with regards to
> > the device/driver/instance creating that message?
>
> No, I don't lose anything. When I do debug I know that all debug
> messages comes from my driver. dev_dbg will give me few device
> identifiers which I don't care so much.

No, you need/want that, trust me.

> IMO, the device information makes more sense to dev_err/warn/err
> variants. On the other side we will have dev_dbg_level(group) if
> still someone needs the device information.

You really want those "gerneric identifiers" as tools today are built to
properly parse and handle them to be able to match and filter on what
device/driver is causing what issue.

Please do not try to create driver-specific prefixes instead, use the
standard the rest of the kernel uses, your driver is not "special" in
this case at all.

> > Ick, no, don't do that.
> >
> > And why is this driver somehow "special" compared to all the rest of
>
> Of course it is special ... to me ;-)

Yes, "special and unique" like all other drivers in the kernel :)

Please work with the infrastructure we have, we have spent a lot of time
and effort to make it uniform to make it easier for users and
developers. Don't regress and try to make driver-specific ways of doing
things, that way lies madness...

thanks,

greg k-h