Re: [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask

Greg Kroah-Hartman
2020-06-09T11:16:29Z

On Tue, Jun 09, 2020 at 01:45:58PM +0300, Stanimir Varbanov wrote:
> This adds description of the level bitmask feature.
>
> Cc: Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> ---
> Documentation/admin-guide/dynamic-debug-howto.rst | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
> index 0dc2eb8e44e5..c2b751fc8a17 100644
> --- a/Documentation/admin-guide/dynamic-debug-howto.rst
> +++ b/Documentation/admin-guide/dynamic-debug-howto.rst
> @@ -208,6 +208,12 @@ line
> line -1605 // the 1605 lines from line 1 to line 1605
> line 1600- // all lines from line 1600 to the end of the file
>
> +level
> + The given level will be a bitmask ANDed with the level of the each ``pr_debug()``
> + callsite. This will allow to group debug messages and show only those of the
> + same level. The -p flag takes precedence over the given level. Note that we can
> + have up to five groups of debug messages.

As was pointed out, this isn't a "level", it's some arbitrary type of
"grouping".

But step back, why? What is wrong with the existing control of dynamic
debug messages that you want to add another type of arbitrary grouping
to it? And who defines that grouping? Will it be
driver/subsystem/arch/author specific? Or kernel-wide?

This feels like it could easily get out of hand really quickly.

Why not just use tracepoints if you really want to be fine-grained?

thanks,

greg k-h