From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anjelique Melendez <anjelique.melendez@oss.qualcomm.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: soc: qcom: qcom,pmic-glink: Add Kaanapali and Glymur compatibles
Date: Fri, 17 Oct 2025 06:53:44 +0200 [thread overview]
Message-ID: <4c48be2d-4bb6-4289-8a48-0d916be253b9@kernel.org> (raw)
In-Reply-To: <20251017003033.268567-2-anjelique.melendez@oss.qualcomm.com>
On 17/10/2025 02:30, Anjelique Melendez wrote:
> Document the Kaanapali and Glymur compatibles used to describe the PMIC
> glink on each platform.
> The Glymur compatible uses Kaanapali as
> fallback.
Why?
>
> Signed-off-by: Anjelique Melendez <anjelique.melendez@oss.qualcomm.com>
> ---
> .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 7085bf88afab..42b5a5d811d0 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -37,12 +37,19 @@ properties:
> - const: qcom,pmic-glink
> - items:
> - enum:
> + - qcom,kaanapali-pmic-glink
> - qcom,milos-pmic-glink
> - qcom,sm8650-pmic-glink
> - qcom,sm8750-pmic-glink
> - qcom,x1e80100-pmic-glink
> - const: qcom,sm8550-pmic-glink
> - const: qcom,pmic-glink
> + - items:
> + - enum:
> + - qcom,glymur-pmic-glink
That's confusing... your commit should explain why.
> + - const: qcom,kaanapali-pmic-glink
> + - const: qcom,sm8550-pmic-glink
> + - const: qcom,pmic-glink
>
> '#address-cells':
> const: 1
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-17 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 0:30 [PATCH 0/3] soc: qcom: pmic_glink: Add support for battery management running on SOCCP Anjelique Melendez
2025-10-17 0:30 ` [PATCH 1/3] dt-bindings: soc: qcom: qcom,pmic-glink: Add Kaanapali and Glymur compatibles Anjelique Melendez
2025-10-17 4:53 ` Krzysztof Kozlowski [this message]
2025-10-17 0:30 ` [PATCH 2/3] soc: qcom: pmic_glink: Add support for SOCCP remoteproc channels Anjelique Melendez
2025-10-17 0:30 ` [PATCH 3/3] soc: qcom: pmic_glink: Add PDR service path and service name to client data Anjelique Melendez
2025-10-19 12:10 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c48be2d-4bb6-4289-8a48-0d916be253b9@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=anjelique.melendez@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox