From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86C3C149C57 for ; Fri, 4 Oct 2024 09:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728033837; cv=none; b=flPVyhOQEzTMSm+nwFoO7jN9wqtNSxaEmfT9zwzq3f2v04DEzuOQO0LR5raGGTR5BJcZbHIw47mPpj36yJofqqxFh98JZLRZauA5WmsNubQyZ48qSk8iqSU8rrDl0iySGXZPHb5uH876VN7mBmtsHgUIYOsvo55XiT1AD2634PI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728033837; c=relaxed/simple; bh=zF81PZbRTtYPLl316AZUu9aKAygPVvRd/9sGlJIia3k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sv+WKfH5Cozs6CD1gDIT9rfJkptq/gcFBzOssF8PTmHoMj1XclaNgq90mT50bgwapb8G67t5c0M7s512HSakZiazaAwtft30/Q8Ucv/q1+nVY+OiCqD1wbqjEO5NBnXqFJ5Lt9lQ3YomVu+k3cy/sPnHu3nGVIl0gNkACm/xANA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RxjvNz3Z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RxjvNz3Z" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 493Hxnkj014547 for ; Fri, 4 Oct 2024 09:23:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1FIajSp9MAFRpYz+j44qj4ddmbDFtR8F8jTGb/CgArY=; b=RxjvNz3ZMDOmM367 FXj/JbFGE2Fd1/khJUdPDiM+303P3mLS/gtsvJIfPunDdwi8XZbvzWE0gtpNA+2a GhvkzcYB5qXz1UIYPL3dCXIIelS8d+FD0l121nn+888BgebngbGrHk5LKJ6Su80O yTRwI9UMHrYOnIxfOOSBbal4PUGHUfcQVmQi56g1dMHYgC6MDLyVIo25EE7mNRNV dqAwYylDhpjrj/5WXKuj/mJdbe08JXG3ejlpp6SUpKhBFEVYHPgsenkCxkipkUa/ VNYqnggv1p9goaXwWF3mULlyjrAvJXSsMOhjFsJXPZwE1jJ3cLbp5BHI2ROkBLxY 1bq/zA== Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42205e1mya-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 04 Oct 2024 09:23:53 +0000 (GMT) Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a8d24f98314so29697166b.0 for ; Fri, 04 Oct 2024 02:23:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728033829; x=1728638629; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1FIajSp9MAFRpYz+j44qj4ddmbDFtR8F8jTGb/CgArY=; b=ea9mtKsDkCQaTHBLsyO6Z+JDBamKC71+/yS1Tz7naUlbCaQKphz76KinjjEv3ce9Ce dAf1ed8dsey1KEka3SCKpq7Ujmo71hi02ISKPyxjgm10YI2qP2ZmdwGu3jzB9+ZiZWLQ 28MJWhclyjTEj4A1jm72vBJsF3jVIOLqQSGhaXDRlAmKECt9HzTvckZYQeeDUN2ufNdS iVUCVe8e3poA4VSxLzP2Im1EINkK1GUdN+LVQPJJdqDvu2ucbuvpKGwwvyL98mTrMSO+ 5Mkvvhdtr/95evc3g8hwwJR6MjW2Qw05bNh3Pu9lAMC126Z2vFJ4CnzmeEeTv7ZM3Ue/ Usfw== X-Forwarded-Encrypted: i=1; AJvYcCX2PbXi0RxpSFHFlP/BT946KHsCM5T9bs50o/WKqWcXImB9efHNIkCxb9lhoPI9LTBCIlZpeiiIbCdWHxI6@vger.kernel.org X-Gm-Message-State: AOJu0YzQW17muKYLz2OF+6mp8qw9UiJpSsa9muavMn8uqg+9zWlUuqOv 3rDqlBMX4rf8t1ptyIL9AX4KDQF85Q3w3AY/lUvqWpDx2jV89+7fqDuaHd1hodMgH7Wuy/LdG4r YUxevqxWcgVD8dgzhSpEeH4L6DeSbNJ/tMq08ZB+HeiwENKEmmrar8ZP5TBl1YlP4GvvgXMGalh Y= X-Received: by 2002:a05:6402:40c5:b0:5c8:8381:c2a0 with SMTP id 4fb4d7f45d1cf-5c8d2cfe1d1mr548322a12.2.1728033829580; Fri, 04 Oct 2024 02:23:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNg5J8Z1YedVbonVK1DkJJLIXofB2Yi/Sdsn9fVSFpZdSMkYXBrS94sDQ7EdFgplzm1UDt6w== X-Received: by 2002:a05:6402:40c5:b0:5c8:8381:c2a0 with SMTP id 4fb4d7f45d1cf-5c8d2cfe1d1mr548309a12.2.1728033829127; Fri, 04 Oct 2024 02:23:49 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c8ca4d7e5dsm1622502a12.61.2024.10.04.02.23.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Oct 2024 02:23:48 -0700 (PDT) Message-ID: <4cdc804b-6b33-4420-a245-1a6db47e17e3@oss.qualcomm.com> Date: Fri, 4 Oct 2024 11:23:46 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: qcom: Enable MSI interrupts together with Link up if global IRQ is supported To: Manivannan Sadhasivam , lpieralisi@kernel.org, kw@linux.com Cc: robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_qianyu@quicinc.com, Konrad Dybcio References: <20240930134409.168494-1-manivannan.sadhasivam@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240930134409.168494-1-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: dPGWOcnNQGg7yIoDR5YguAx00aOHf8HA X-Proofpoint-ORIG-GUID: dPGWOcnNQGg7yIoDR5YguAx00aOHf8HA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 phishscore=0 mlxlogscore=715 mlxscore=0 adultscore=0 bulkscore=0 priorityscore=1501 clxscore=1011 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410040068 On 30.09.2024 3:44 PM, Manivannan Sadhasivam wrote: > Currently, if global IRQ is supported by the platform, only the Link up > interrupt is enabled in the PARF_INT_ALL_MASK register. But on some Qcom > platforms like SM8250, and X1E80100, MSIs are getting masked due to this. > They require enabling the MSI interrupt bits in the register to unmask > (enable) the MSIs. > > Even though the MSI interrupt enable bits in PARF_INT_ALL_MASK are > described as 'diagnostic' interrupts in the internal documentation, > disabling them masks MSI on these platforms. Due to this, MSIs were not > reported to be received these platforms while supporting global IRQ. > > So enable the MSI interrupts along with the Link up interrupt in the > PARF_INT_ALL_MASK register if global IRQ is supported. This ensures that > the MSIs continue to work and also the driver is able to catch the Link > up interrupt for enumerating endpoint devices. > > Fixes: 4581403f6792 ("PCI: qcom: Enumerate endpoints based on Link up event in 'global_irq' interrupt") > Reported-by: Konrad Dybcio > Closes: https://lore.kernel.org/linux-pci/9a692c98-eb0a-4d86-b642-ea655981ff53@kernel.org/ > Signed-off-by: Manivannan Sadhasivam > --- Tested-by: Konrad Dybcio # SL7 Konrad