From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DADC6FD1D for ; Thu, 23 Mar 2023 14:48:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231611AbjCWOsM (ORCPT ); Thu, 23 Mar 2023 10:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231552AbjCWOsL (ORCPT ); Thu, 23 Mar 2023 10:48:11 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 17401DBE2; Thu, 23 Mar 2023 07:48:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D3BDF4B3; Thu, 23 Mar 2023 07:48:53 -0700 (PDT) Received: from [10.57.53.151] (unknown [10.57.53.151]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C80A3F6C4; Thu, 23 Mar 2023 07:48:06 -0700 (PDT) Message-ID: <4cde9235-e86a-73a0-5c6c-ac193328006b@arm.com> Date: Thu, 23 Mar 2023 14:48:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 04/11] coresight-tpdm: Add reset node to TPDM node From: Suzuki K Poulose To: Tao Zhang , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org References: <1679551448-19160-1-git-send-email-quic_taozha@quicinc.com> <1679551448-19160-5-git-send-email-quic_taozha@quicinc.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/03/2023 14:41, Suzuki K Poulose wrote: > On 23/03/2023 06:04, Tao Zhang wrote: >> TPDM device need a node to reset the configurations and status of >> it. This change provides a node to reset the configurations and >> disable the TPDM if it has been enabled. Please justify why this "do everything" magic knob is required when there are tunables for individual controls in the later patches. Suzuki >> >> Signed-off-by: Tao Zhang >> --- >>   drivers/hwtracing/coresight/coresight-tpdm.c | 28 >> ++++++++++++++++++++++++++++ >>   1 file changed, 28 insertions(+) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c >> b/drivers/hwtracing/coresight/coresight-tpdm.c >> index 5e1e2ba..104638d 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpdm.c >> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c >> @@ -161,6 +161,33 @@ static void tpdm_datasets_setup(struct >> tpdm_drvdata *drvdata) >>       drvdata->datasets |= pidr & GENMASK(TPDM_DATASETS - 1, 0); >>   } >> +static ssize_t reset_store(struct device *dev, >> +                      struct device_attribute *attr, >> +                      const char *buf, >> +                      size_t size) >> +{ >> +    int ret = 0; >> +    unsigned long val; >> +    struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + >> +    ret = kstrtoul(buf, 10, &val); >> +    if (ret || val != 1) >> +        return -EINVAL; >> + >> +    spin_lock(&drvdata->spinlock); >> +    /* Reset all datasets to ZERO, and init the default data*/ >> +    tpdm_init_datasets(drvdata); > > With the suggested rename in the previous patch, you wouldn't need > a comment here. > >> + >> +    spin_unlock(&drvdata->spinlock); >> + > > >> +    /* Disable tpdm if enabled */ >> +    if (drvdata->enable) >> +        coresight_disable(drvdata->csdev); > > Couldn't this be done via disable_source ? Please don't overload > the sysfs handle. > >> + >> +    return size; >> +} >> +static DEVICE_ATTR_WO(reset); > > Documentation for the sysfs node please ? > > Suzuki >