From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Melody Olvera <quic_molvera@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: qdu1000: Add IPCC, MPSS, AOSS nodes
Date: Tue, 14 Mar 2023 11:55:36 +0100 [thread overview]
Message-ID: <4d7d3d5a-4a3c-44ab-6f32-ddee2cb621fc@linaro.org> (raw)
In-Reply-To: <3ee969ec-faae-fd9f-d583-6a8e2670b567@quicinc.com>
On 13.03.2023 22:25, Melody Olvera wrote:
>
>
> On 3/8/2023 2:23 AM, Konrad Dybcio wrote:
>>
>> On 7.03.2023 00:17, Melody Olvera wrote:
>>> Add nodes for IPCC, MPSS, and AOSS drivers. Also update
>>> the scm node to include its interconnect.
>> Quite a bit of stuff in a single commit, this could be
>> separated into:
>>
>> - scm icc
>> - aoss+ipcc
>> - smp2p+mpss
>
> Hmm ok. Will split this patch into a few patches.
>
>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
[...]
>>> + <0x0 0x4180000 0x0 0x1000>;
>> No reg-names?
>
> No; we don't use reg-names in the driver. Lmk if we should be.
>
qcom_q6v5_mss.c / qcom_q6v5_wcss.c get the 'rmb' region with
[...]_byname and I think it'd scale better if we did the same here,
as one day there may be a weird SoC that'd have an "XYZ" region,
different to "base" and "rmb", which we would need to handle.. somehow..
Konrad
next prev parent reply other threads:[~2023-03-14 10:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 23:17 [PATCH v2 0/3] arm64: dts: qcom: Add mpss support to QDU1000/QRU1000 SoCs Melody Olvera
2023-03-06 23:17 ` [PATCH v2 1/3] arm64: dts: qcom: qdu1000: Add IPCC, MPSS, AOSS nodes Melody Olvera
2023-03-08 10:23 ` Konrad Dybcio
2023-03-13 21:25 ` Melody Olvera
2023-03-14 10:55 ` Konrad Dybcio [this message]
2023-03-20 23:28 ` Melody Olvera
2023-03-06 23:17 ` [PATCH v2 2/3] arm64: dts: qcom: qdu1000-idp: Enable mpss Melody Olvera
2023-03-08 10:24 ` Konrad Dybcio
2023-03-06 23:17 ` [PATCH v2 3/3] arm64: dts: qcom: qru1000-idp: " Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d7d3d5a-4a3c-44ab-6f32-ddee2cb621fc@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_molvera@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox