From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeffrey Hugo <jhugo@codeaurora.org>
Subject: Re: [PATCH v3 2/5] arm64: dts: qcom: msm8998: Allow drivers to
 set-load
Date: Mon, 4 Feb 2019 11:06:52 -0700
Message-ID: <4d99d729-d59c-e799-b4f2-8874372c9e63@codeaurora.org>
References: <e3c82a49-c601-effc-348f-f768656c659f@free.fr>
 <31108a78-e158-5147-2f2f-cd300cb5d49b@free.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <31108a78-e158-5147-2f2f-cd300cb5d49b@free.fr>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
To: Marc Gonzalez <marc.w.gonzalez@free.fr>, MSM <linux-arm-msm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, Evan Green <evgreen@chromium.org>, Douglas Anderson <dianders@chromium.org>
List-Id: linux-arm-msm@vger.kernel.org

On 2/4/2019 10:37 AM, Marc Gonzalez wrote:
> The UFS host controller driver needs to set the load on 3 power rails
> (l20, l26, s4) but the operation fails silently unless we specify the
> regulator-allow-set-load property in the corresponding DT nodes.
> 
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---

Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>

>   arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> index 80075283847a..198885db775e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> @@ -104,6 +104,7 @@
>   		vreg_s4a_1p8: s4 {
>   			regulator-min-microvolt = <1800000>;
>   			regulator-max-microvolt = <1800000>;
> +			regulator-allow-set-load;
>   		};
>   		vreg_s5a_2p04: s5 {
>   			regulator-min-microvolt = <1904000>;
> @@ -188,6 +189,7 @@
>   		vreg_l20a_2p95: l20 {
>   			regulator-min-microvolt = <2960000>;
>   			regulator-max-microvolt = <2960000>;
> +			regulator-allow-set-load;
>   		};
>   		vreg_l21a_2p95: l21 {
>   			regulator-min-microvolt = <2960000>;
> @@ -212,6 +214,7 @@
>   		vreg_l26a_1p2: l26 {
>   			regulator-min-microvolt = <1200000>;
>   			regulator-max-microvolt = <1200000>;
> +			regulator-allow-set-load;
>   		};
>   		vreg_l28_3p0: l28 {
>   			regulator-min-microvolt = <3008000>;
> 


-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.