From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17DEC77B7E for ; Thu, 1 Jun 2023 10:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233102AbjFAKBB (ORCPT ); Thu, 1 Jun 2023 06:01:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233095AbjFAKAe (ORCPT ); Thu, 1 Jun 2023 06:00:34 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4067189 for ; Thu, 1 Jun 2023 03:00:27 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2b1a66e71f9so1755701fa.2 for ; Thu, 01 Jun 2023 03:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685613626; x=1688205626; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u1J6cSNjkU1PSmW5vvUQuR8bOMv9ZvpvC+yJyx0cAHY=; b=KcmXUuoNS63f0AdaHzH9QXTRPgBV5P7YMqNgLn6wnIVMtdqF+6lMpsJpLmYVyvJ+bQ xKuYYCBADICQxT11gJEFkAcDXqFkR4MT/akgfSqENZFa25C4dWaBKcvt9xeWcrEeaAa/ Dz6qt1AyJMhKgCMBy1diAPxovV9jBppTb/cJAoXcA0uPRYolLGDFxYH6vfbLmkgur958 eMfWrLAjw+8XW2uJXTINFSQm1nfbvKFoAEs8A2nCRy7JhwqrJGpGM5uCCB/eSVRpSM/A xQTHkJfI3Cwh3fDVGnIZdQp8VKXt8d2m5XOKOWlOcO7BEI2QmB6r46Ybq1Vttq3mgoEp NcWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685613626; x=1688205626; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u1J6cSNjkU1PSmW5vvUQuR8bOMv9ZvpvC+yJyx0cAHY=; b=dS/mfX3RoLYshTyT43LyM0iH2osJo/Fu+1zCZTXlKDH3WeqbBUXLzC5IhcobiY9TYt rAsIvuCBKYLsgservpbU0XVkb/5tgSQGdSGs1ByOPV7Vp/bDvpRheyOELgoI4rm5GNav 369i41dbS+l5d/lajSOviimYWgh1B+6DWXX0V7ou+/98AUjddSPROE8aMDvGk786trZB epvMXydimbJy9zFLCTSrm/6AuZitZEsr709B0gpgRFcY8qAS94sbRm74VXIvcM6b3EqV zf8KBITcvgI4X+j2xAnp9OItfhCNKko79EKKc1OYXX1RunHg2s7mOj7gMrvNa2FisM9w 02Qg== X-Gm-Message-State: AC+VfDxH191D3ROKh/Bi+T0bsVSu/PhF7d3bnGvzTzwUScVrf/QuUpfs TMThrDcSEtg83TibDLr/xAXzvg== X-Google-Smtp-Source: ACHHUZ5CJPaPVSQKeTr9nKO3KvVbKe+1gyc1FlbV8V0wrvCSJ7xknGpEQ3aqVlYfXK1+DlLZwmmm8Q== X-Received: by 2002:a2e:9f02:0:b0:2a7:653d:166c with SMTP id u2-20020a2e9f02000000b002a7653d166cmr4650500ljk.3.1685613626188; Thu, 01 Jun 2023 03:00:26 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id n10-20020a2e878a000000b002afd30401b0sm3714860lji.138.2023.06.01.03.00.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 03:00:25 -0700 (PDT) Message-ID: <4de7d05a-91da-501c-2889-4eee8e3bd34f@linaro.org> Date: Thu, 1 Jun 2023 12:00:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 07/20] interconnect: qcom: Fold smd-rpm.h into icc-rpm.h Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Leo Yan , Evan Green Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org References: <20230526-topic-smd_icc-v1-0-1bf8e6663c4e@linaro.org> <20230526-topic-smd_icc-v1-7-1bf8e6663c4e@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 1.06.2023 11:57, Dmitry Baryshkov wrote: > On 30/05/2023 13:20, Konrad Dybcio wrote: >> smd-rpm.h is not very useful as-is and both files are always included >> anyway.. Combine them. > > If we ever add interconnect driver for non-SMD RPM platforms (like MSM8960/APQ8064), we can just ignore the smd part. icc-rpm sends requests via smd so that doesn't sound unifiable Konrad > >> Signed-off-by: Konrad Dybcio >> --- >>   drivers/interconnect/qcom/icc-rpm.c |  1 - >>   drivers/interconnect/qcom/icc-rpm.h |  5 +++++ >>   drivers/interconnect/qcom/msm8916.c |  1 - >>   drivers/interconnect/qcom/msm8939.c |  1 - >>   drivers/interconnect/qcom/msm8974.c |  2 +- >>   drivers/interconnect/qcom/msm8996.c |  1 - >>   drivers/interconnect/qcom/qcm2290.c |  1 - >>   drivers/interconnect/qcom/qcs404.c  |  1 - >>   drivers/interconnect/qcom/sdm660.c  |  1 - >>   drivers/interconnect/qcom/smd-rpm.c |  2 +- >>   drivers/interconnect/qcom/smd-rpm.h | 15 --------------- >>   11 files changed, 7 insertions(+), 24 deletions(-) > > Reviewed-by: Dmitry Baryshkov >