* [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK [not found] ` <201704062226.0RxDxHDj%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2017-04-06 20:07 ` Vivek Gautam 2017-04-10 5:22 ` Kishon Vijay Abraham I 0 siblings, 1 reply; 3+ messages in thread From: Vivek Gautam @ 2017-04-06 20:07 UTC (permalink / raw) To: kishon-l0cyMroinI0 Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, sboyd-sgV2jX0FEOL9JmXXK+q4OQ, bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, Vivek Gautam, Fengguang Wu The driver uses clock provider interface, and therefore it fails to build when enabled for COMPILE_TEST, since COMMON_CLK is not enabled at that time. So, make PHY_QCOM_QMP depend on COMMON_CLK as well. Cc: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org> Signed-off-by: Vivek Gautam <vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> --- Hi Kishon, This patch is fixing the build failures for architectures such as, tile, and ia64, that don't enable COMMON_CLK by default. You can either squash this into the qmp phy driver patch, or put it as a separate patch with 'Fix' tag. Let me know if you want me to add a 'fix' tag with a reference to the commit ID. Regards Vivek drivers/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index bb8140355608..8550d3dc0b71 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -441,7 +441,7 @@ config PHY_STIH407_USB config PHY_QCOM_QMP tristate "Qualcomm QMP PHY Driver" - depends on OF && (ARCH_QCOM || COMPILE_TEST) + depends on OF && COMMON_CLK && (ARCH_QCOM || COMPILE_TEST) select GENERIC_PHY help Enable this to support the QMP PHY transceiver that is used -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK 2017-04-06 20:07 ` [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK Vivek Gautam @ 2017-04-10 5:22 ` Kishon Vijay Abraham I 2017-04-10 7:05 ` Vivek Gautam 0 siblings, 1 reply; 3+ messages in thread From: Kishon Vijay Abraham I @ 2017-04-10 5:22 UTC (permalink / raw) To: Vivek Gautam Cc: linux-arm-msm, linux-kernel, linux-usb, sboyd, bjorn.andersson, srinivas.kandagatla, Fengguang Wu On Friday 07 April 2017 01:37 AM, Vivek Gautam wrote: > The driver uses clock provider interface, and therefore > it fails to build when enabled for COMPILE_TEST, since > COMMON_CLK is not enabled at that time. > So, make PHY_QCOM_QMP depend on COMMON_CLK as well. > > Cc: Fengguang Wu <fengguang.wu@intel.com> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > > Hi Kishon, > > This patch is fixing the build failures for architectures > such as, tile, and ia64, that don't enable COMMON_CLK by default. > You can either squash this into the qmp phy driver patch, > or put it as a separate patch with 'Fix' tag. > Let me know if you want me to add a 'fix' tag with a reference > to the commit ID. I squashed it with your earlier patch and pushed. Thanks Kishon > > Regards > Vivek > > drivers/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index bb8140355608..8550d3dc0b71 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -441,7 +441,7 @@ config PHY_STIH407_USB > > config PHY_QCOM_QMP > tristate "Qualcomm QMP PHY Driver" > - depends on OF && (ARCH_QCOM || COMPILE_TEST) > + depends on OF && COMMON_CLK && (ARCH_QCOM || COMPILE_TEST) > select GENERIC_PHY > help > Enable this to support the QMP PHY transceiver that is used > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK 2017-04-10 5:22 ` Kishon Vijay Abraham I @ 2017-04-10 7:05 ` Vivek Gautam 0 siblings, 0 replies; 3+ messages in thread From: Vivek Gautam @ 2017-04-10 7:05 UTC (permalink / raw) To: Kishon Vijay Abraham I Cc: linux-arm-msm, linux-kernel, linux-usb, sboyd, bjorn.andersson, srinivas.kandagatla, Fengguang Wu, linux-arm-msm-owner On 2017-04-10 10:52, Kishon Vijay Abraham I wrote: > On Friday 07 April 2017 01:37 AM, Vivek Gautam wrote: >> The driver uses clock provider interface, and therefore >> it fails to build when enabled for COMPILE_TEST, since >> COMMON_CLK is not enabled at that time. >> So, make PHY_QCOM_QMP depend on COMMON_CLK as well. >> >> Cc: Fengguang Wu <fengguang.wu@intel.com> >> Cc: Kishon Vijay Abraham I <kishon@ti.com> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- >> >> Hi Kishon, >> >> This patch is fixing the build failures for architectures >> such as, tile, and ia64, that don't enable COMMON_CLK by default. >> You can either squash this into the qmp phy driver patch, >> or put it as a separate patch with 'Fix' tag. >> Let me know if you want me to add a 'fix' tag with a reference >> to the commit ID. > > I squashed it with your earlier patch and pushed. Thanks Kishon. Regards Vivek > > Thanks > Kishon > >> >> Regards >> Vivek >> >> drivers/phy/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index bb8140355608..8550d3dc0b71 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -441,7 +441,7 @@ config PHY_STIH407_USB >> >> config PHY_QCOM_QMP >> tristate "Qualcomm QMP PHY Driver" >> - depends on OF && (ARCH_QCOM || COMPILE_TEST) >> + depends on OF && COMMON_CLK && (ARCH_QCOM || COMPILE_TEST) >> select GENERIC_PHY >> help >> Enable this to support the QMP PHY transceiver that is used >> > -- > To unsubscribe from this list: send the line "unsubscribe > linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-10 7:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201704062226.0RxDxHDj%fengguang.wu@intel.com>
[not found] ` <201704062226.0RxDxHDj%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-06 20:07 ` [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK Vivek Gautam
2017-04-10 5:22 ` Kishon Vijay Abraham I
2017-04-10 7:05 ` Vivek Gautam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).