From: Manu Gautam <mgautam@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Varadarajan Narayanan <varada@codeaurora.org>,
Wei Yongjun <weiyongjun1@huawei.com>,
Fengguang Wu <fengguang.wu@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file
Date: Thu, 23 Nov 2017 09:32:26 +0530 [thread overview]
Message-ID: <4ee6af23-7b09-c25b-9e79-f08373a88826@codeaurora.org> (raw)
In-Reply-To: <bedafa8b-e09f-cc01-9932-4f117377181c@codeaurora.org>
Hi,
On 11/22/2017 10:56 PM, Stephen Boyd wrote:
> On 11/21/2017 01:23 AM, Manu Gautam wrote:
>> New revision (v3) of QMP PHY uses different offsets
>> for almost all of the registers. Hence, move these
>> definitions to header file so that updated offsets
>> can be added for QMP v3.
>>
>> Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
>> ---
> Why? It would only be included into one C file so it's really not necessary.
Yes, it is not necessary but it keep QMP PHY driver clean. V3 PHY duplicates all the
#defines and this could continue for future revisions as well.
Please refer to this patch:
- [PATCH v3 11/16] phy: qcom-qmp: Add register offsets for QMP V3 PHY
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-11-23 4:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 9:23 [PATCH v3 00/16] Support for Qualcomm QUSBv2 and QMPv3 USB PHYs Manu Gautam
2017-11-21 9:23 ` [PATCH v3 01/16] phy: qcom-qmp: Fix phy pipe clock gating Manu Gautam
2017-11-21 9:23 ` [PATCH v3 02/16] phy: qcom-qmp: Adapt to clk_bulk_* APIs Manu Gautam
2017-12-20 2:37 ` Vivek Gautam
[not found] ` <CAFp+6iEgiv0KJo+ikR_jyakc2dGjetiArJSvC4d5JFO0ZnO7-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-20 5:03 ` Manu Gautam
2017-11-21 9:23 ` [PATCH v3 03/16] phy: qcom-qmp: Power-on PHY before initialization Manu Gautam
2017-11-22 18:03 ` Stephen Boyd
2017-11-23 3:59 ` Manu Gautam
2017-11-21 9:23 ` [PATCH v3 04/16] phy: qcom-qusb2: " Manu Gautam
2017-11-21 9:23 ` [PATCH v3 05/16] phy: qcom-qmp: Fix PHY block reset sequence Manu Gautam
2017-11-21 9:23 ` [PATCH v3 06/16] phy: qcom-qmp: Move SERDES/PCS START after PHY reset Manu Gautam
2017-11-21 9:23 ` [PATCH v3 07/16] phy: qcom-qusb2: Add support for different register layouts Manu Gautam
2017-12-05 10:23 ` Vivek Gautam
[not found] ` <3c0dca03-bf9e-8747-8c31-546172f88d6f-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-12 8:51 ` Manu Gautam
2017-11-21 9:23 ` [PATCH v3 08/16] dt-bindings: phy-qcom-qusb2: Update binding for QUSB2 V2 version Manu Gautam
2017-11-21 9:23 ` [PATCH v3 09/16] phy: qcom-qusb2: Add support " Manu Gautam
2017-11-21 9:23 ` [PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file Manu Gautam
2017-11-22 17:26 ` Stephen Boyd
2017-11-23 4:02 ` Manu Gautam [this message]
2017-11-21 9:23 ` [PATCH v3 11/16] phy: qcom-qmp: Add register offsets for QMP V3 PHY Manu Gautam
2017-11-21 9:23 ` [PATCH v3 12/16] dt-bindings: phy-qcom-qmp: Update bindings for QMP V3 USB PHY Manu Gautam
2017-11-21 9:23 ` [PATCH v3 13/16] phy: qcom-qmp: Add support for QMP V3 USB3 PHY Manu Gautam
2017-11-21 9:23 ` [PATCH v3 14/16] phy: Add notify_speed callback Manu Gautam
2017-12-12 11:43 ` Kishon Vijay Abraham I
2017-12-12 15:24 ` Manu Gautam
2017-12-20 5:49 ` Kishon Vijay Abraham I
2017-12-20 6:29 ` Manu Gautam
2017-12-20 7:17 ` Kishon Vijay Abraham I
2017-12-20 8:41 ` Manu Gautam
2017-12-28 11:04 ` Kishon Vijay Abraham I
2017-12-29 4:24 ` Manu Gautam
2017-12-29 6:28 ` Kishon Vijay Abraham I
2018-01-02 5:42 ` Manu Gautam
2017-11-21 9:23 ` [PATCH v3 15/16] phy: qcom-qusb2: Add support for runtime PM Manu Gautam
2017-11-21 9:23 ` [PATCH v3 16/16] phy: qcom-qmp: " Manu Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ee6af23-7b09-c25b-9e79-f08373a88826@codeaurora.org \
--to=mgautam@codeaurora.org \
--cc=fengguang.wu@intel.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=varada@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).