From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 764A2352C5B for ; Sat, 9 May 2026 17:07:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778346453; cv=none; b=Bula/7i+pIGhaUDslCx3ceCR+sk4eI8xhAntfx+CFZ04hasAx0NjgjGauycziRysUCkVPobB5JWDW7h3mTvDokv/icAfQ7sGUzjSBuTCLlEFZv5Q5c+3Fxde+ruFinhm3I+ZXbi3QiiO/kdMirHETPp9xTPUTztwMFFqLDEkNHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778346453; c=relaxed/simple; bh=QhhESLt4sU4La0hv5PEaGGtWswEN/2rxsz2V4OX7lNc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YmVQrp8Oixf4LIKK73chWR88wDK0cJCRq4j97455+hd1ivPcdEPZlKKOk+c1YYtTkEil4RcDnx4+vjHMbWWgIMEqT4W/8RFvIlpeo2tZJ5hyWfJzN9GEYsYN2g9EdYNFBAbtKR4Oh7YnKUy4fKXzd0m2fj2WFSHTVJwm2aIRus8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PSvGJXcZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dTGxJVFQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PSvGJXcZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dTGxJVFQ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6494C0Tj3799731 for ; Sat, 9 May 2026 17:07:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NK26YkhXhOkB1zXXrflzYxxjD7OJUQPCc6PGnNHByaw=; b=PSvGJXcZAgrUyxaM U6HDSgO1E2DllbScsXkg2vFzairaUrRNUwT/eHB8sNtYb9Mi7QIPIy9oRuPp6vTX qvqZRxKGECeOJAlfKPy/tChHjGd3dsC3WQJRMuKXFTcs30wkjWhlQQS4IXA5w7/p HBCSU6AEzIdjXCyIKsoOYmhpMEhezBnUYxN6RrWPmSg19rXe30Gas6nCH1SOJnPM AEA+TWemEm0jcVf5UooqQbDMp/fWsupOsSgjZzz+wuPDfLlBOu77UV2Bzx9WcaXz y/werDFzZw+zG/79CrF4/vSovF3+4jEul/RGYwcb/AftErqGrCTWy32yDRypTCXd xaWKfw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1wpe9a0a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 09 May 2026 17:07:30 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-82f74bcfb86so3024253b3a.0 for ; Sat, 09 May 2026 10:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778346450; x=1778951250; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NK26YkhXhOkB1zXXrflzYxxjD7OJUQPCc6PGnNHByaw=; b=dTGxJVFQiTaBKsL+BfuBkxMentqIeLAPLjwIvrxdIfEJ9osiJ5jbNsa0+MlqaDFS5Z 9rUeAJqluZ/Z3peGiiCtrh743MATwtR1yLcYfwNg+97+Mb/79a13w1muoxbupSeN4+B9 wL9QDhuqyEcEKf4U4pIIsv8G3NTgfjWFsHr+8Por0dGTwrztv+1nQc7tDlQS0nRL3rVP oVpwLBep3K/DGlq/14GbB2NrAQDTZQGS+YN3ZV32OFY0jD/Ut0lBAVMNa9lU6H/BYzdm oiCtUkNXPs5P0kjjLDGklyVNHIAy1zpkplRwS5rr6zw6ovgJoQnP8GeCKpqFv9YtTpkd HCxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778346450; x=1778951250; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NK26YkhXhOkB1zXXrflzYxxjD7OJUQPCc6PGnNHByaw=; b=ZxBiqxBVDH+zU5O1wsIgk7bsyi+RJvX+OcA74ZNz5CEyEVZz74xS83I5dALkod8JVW ji1InI64MeeY0VI0KWu/ls3V8rP+Zml0+iRzBdaVPPmSbQw/SEiMhu/XuvgGAHP6MXur xr6YboG5lQwNDkN27QVQIMxQLNoGPGL7Gcvj9RnfKnAPzttmC0H09cdrRz8WmY7276Pm GJjgdlFzC35r2AaQLEdSuvmEqIqWT7GV+F+myTRBOQTGZNod2a/y8WJwE9wAeKEUpXS5 u8+B/lXInMhtZXzINaNcFAONv7+V0gOgBoxj3B6MHCQZA7lCWMsSZn+lQmRL1OymTy/T H3Gg== X-Forwarded-Encrypted: i=1; AFNElJ+Isb6oDspd8anVGuuQ3THO2Houe/cbGS7Os0jEsWUtLqVazyx5E2g8xhUaa99oMVqHOs6d1TxuIOPx1hmi@vger.kernel.org X-Gm-Message-State: AOJu0YxOKu51AcTpKm/URl/46boANcd7WfZUboA/N5Ng+oNQjyeCcXsd 9DbpDrNMkMeUQeADIOG+OnDtA/ravSVOpfHG9PLBShseuLnnZHXCeRECqaQ9RZuzu+w4Uiou9qn gaJsoCNkjnNWo4zjVcUAnxuD2ch6Nvj61Xt1meei0pKJ1kInAIpLHPlT5VbNtUoWT0MXf X-Gm-Gg: Acq92OHfCMvAcAsfRxFnZr+01qvqzmD7QLmnL5SP4WaauV8ILgJeW4h3QzY/2SbIApR l5wfGavd34L6Vaa/r/Ew7TJS7BvRIL1Yptx7UxmWUsmD0eMY1MlyU6/ysfbizTvHUCvqtcMKvOa i5qr25AH3e4hrwSrtNFtrNrlhrRQCkj3i1mbAhWCPFJxBstFH2m0PWS3wvPEgE63WttmZHYeB9l fgCQVyuOTACIiaKE9HeWXMWx7tGxCGSNX3D7qe0naogTBONgkB1V8ZB/h8NH2WTz+ANL6NO7KZc pYwLbKslrJEjKLXeMWen1ePXKvKhZ66d03Avd1QYbTNxxa/Wocj4LpJUxf0XVYzOvJVG1F3iQ75 LEu+QnGuBch21hX+phO9vX5f4Rp8dEh4CPDacLrlHoG1snf5KNfmTTo12FfTkhw== X-Received: by 2002:a05:6a00:1303:b0:81f:3f03:6846 with SMTP id d2e1a72fcca58-83e3bf8eaf4mr2810761b3a.47.1778346450096; Sat, 09 May 2026 10:07:30 -0700 (PDT) X-Received: by 2002:a05:6a00:1303:b0:81f:3f03:6846 with SMTP id d2e1a72fcca58-83e3bf8eaf4mr2810726b3a.47.1778346449532; Sat, 09 May 2026 10:07:29 -0700 (PDT) Received: from [192.168.0.9] ([49.205.255.40]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83967dbee14sm20911031b3a.48.2026.05.09.10.07.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2026 10:07:29 -0700 (PDT) Message-ID: <4eef8b17-47b5-e8f0-4a44-87fdf1d69d18@oss.qualcomm.com> Date: Sat, 9 May 2026 22:37:20 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v5 08/14] media: iris: Rename clock and power domain macros to use vcodec prefix Content-Language: en-US To: Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Joerg Roedel , Will Deacon , Robin Murphy , Hans Verkuil , Stefan Schmidt , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Jorge Ramirez-Ortiz , Del Regno , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, Krzysztof Kozlowski , devicetree@vger.kernel.org References: <20260509-glymur-v5-0-7fbb340c5dbd@oss.qualcomm.com> <20260509-glymur-v5-8-7fbb340c5dbd@oss.qualcomm.com> <6hr42ins65rf6ftdmme5lok6ham67piz3343kdwxaff2acktcz@oipdhket32og> From: Vishnu Reddy In-Reply-To: <6hr42ins65rf6ftdmme5lok6ham67piz3343kdwxaff2acktcz@oipdhket32og> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: INJ165SfcznUnr0NLV0mdzWS9BYNM7w5 X-Proofpoint-ORIG-GUID: INJ165SfcznUnr0NLV0mdzWS9BYNM7w5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA5MDE4NiBTYWx0ZWRfXz08iZ086Us4E kFjFJjg/d4kB+ecEblxM9rsAbuxHbpUs50skPsP9ZFFTj/geVh3klV1PUOKESvRzcQx6cv2KhvV wbtXaKtiY09bTtrjcjwzMnLOzzBIhVk6pBaoSP4aL/GdaE7lRi7fokS25+yxSnFlazXA6VFb2RL 6W/8s7kINicprDMMUl5n2CbYdKIwwCAcGI/KMxeY7HyPKwDWxI5lBZUSo2Z/n1JE56XwrwDvnM/ hctNLLyRihifqn/HB+KVGZQDIfy/+BxgtSBoX7ic0wM721uvYmlvGYiSMBMC0Womws5MwZP4JSg a5nn0QXz+rNvL64fQ7VVZK/Jex6KMqoLG003+mP1GTOeKXsJIu9FS4VAHSn+jn/QjprGr25BLMK /G4HodGi/39lxUcdWRlu0ouGnh+jXJjhhKH/835+lbeV88OTklgPLyeN1BGBUHJHOaMnn0qzvXn iVNmML/+mk/gMxutIEw== X-Authority-Analysis: v=2.4 cv=EeD4hvmC c=1 sm=1 tr=0 ts=69ff69d2 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=SpcZ+gRb+6o1zy8jT5J+bQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=2nvh9x2cStbi1KpodkAA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-09_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605090186 On 5/9/2026 1:52 AM, Dmitry Baryshkov wrote: > On Sat, May 09, 2026 at 12:29:57AM +0530, Vishnu Reddy wrote: >> The current clock and power domain enum names are too generic. Rename >> them with a vcodec prefix to make the names more meaningful and to easily >> accommodate vcodec1 enums for the secondary core for glymur platform. >> >> No functional changes intended. >> >> Reviewed-by: Vikash Garodia >> Signed-off-by: Vishnu Reddy >> --- >> .../platform/qcom/iris/iris_platform_common.h | 12 ++++---- >> .../media/platform/qcom/iris/iris_platform_gen1.c | 6 ++-- >> .../media/platform/qcom/iris/iris_platform_gen2.c | 6 ++-- >> .../platform/qcom/iris/iris_platform_sc7280.h | 10 +++---- >> .../platform/qcom/iris/iris_platform_sm8750.h | 12 ++++---- >> drivers/media/platform/qcom/iris/iris_vpu3x.c | 21 +++++++------- >> drivers/media/platform/qcom/iris/iris_vpu4x.c | 30 +++++++++++--------- >> drivers/media/platform/qcom/iris/iris_vpu_common.c | 33 +++++++++++----------- >> 8 files changed, 67 insertions(+), 63 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h >> index 55ff6137d9a9..30e9d4d288c6 100644 >> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h >> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h >> @@ -49,14 +49,14 @@ extern const struct iris_platform_data sm8650_data; >> extern const struct iris_platform_data sm8750_data; >> >> enum platform_clk_type { >> - IRIS_AXI_CLK, /* AXI0 in case of platforms with multiple AXI clocks */ >> + IRIS_AXI_VCODEC_CLK, >> IRIS_CTRL_CLK, >> IRIS_AHB_CLK, >> - IRIS_HW_CLK, >> - IRIS_HW_AHB_CLK, >> - IRIS_AXI1_CLK, >> + IRIS_VCODEC_CLK, >> + IRIS_VCODEC_AHB_CLK, >> + IRIS_AXI_CTRL_CLK, > Why AXI_CTRL is better than AXI1? Glymur has 3 AXI clocks: axi_vcodec0, axi_ctrl, and axi_vcodec1. Using positional names like AXI0/AXI1/AXI2 doesn't convey their purpose, whereas naming them as AXI_VCODEC_CLK, AXI_CTRL_CLK makes the intent clearer, especially when platforms differ in the number of AXI clocks they expose. > >> IRIS_CTRL_FREERUN_CLK, >> - IRIS_HW_FREERUN_CLK, >> + IRIS_VCODEC_FREERUN_CLK, > Can we at least group them too? > >> IRIS_BSE_HW_CLK, > Is BSE a core or a codec clock? > >> IRIS_VPP0_HW_CLK, >> IRIS_VPP1_HW_CLK, >> @@ -206,7 +206,7 @@ struct icc_vote_data { >> >> enum platform_pm_domain_type { >> IRIS_CTRL_POWER_DOMAIN, >> - IRIS_HW_POWER_DOMAIN, >> + IRIS_VCODEC_POWER_DOMAIN, >> IRIS_VPP0_HW_POWER_DOMAIN, >> IRIS_VPP1_HW_POWER_DOMAIN, >> IRIS_APV_HW_POWER_DOMAIN,