From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DF40304980 for ; Tue, 2 Dec 2025 07:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764662139; cv=none; b=W5Iapb42ySeJXB5xVUxUrY90pcpup6DLemuhA0MqXA2bJq8d7Zv8qEI6MCOKXhaIX8u9t5H6yujN+mk8w88HV52L0xvO91BX7Np4DGc7MemTOBS7Q7aFywcl7xTbNYiY46CYlhc7pYKgdspejzZ1pe2MI5mS0cjzJNNUUGEzjhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764662139; c=relaxed/simple; bh=qiZ55Y0YRim6hw7FUpbTQeymDxT4IMit+Hcld2r/oCw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WbmaGbHtpFV1Wp2k1lD8eXnbzmyl8ZjBgfEVafZJhV0mf5zM5fJcGKfgYc0MTRo7J0+zNFwtSPv4mFd9l/DSUDxcYbFNjuU73zI9fC6opTrarXFAqZWDorgTqzUMH4G0PuddmXnVbYqtmrRyF9L+gYDpc/KKWz2dGFfuIyQrQRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i/B/43rx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b2kWoHXb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i/B/43rx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b2kWoHXb" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B22klCE1093016 for ; Tue, 2 Dec 2025 07:55:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wya6bVI7BEkGEtZdZUR36jM/nyPYy5oPLlPIXVCOb30=; b=i/B/43rxlqcUc9SM EuNpnImqXgLWbV05MNX4DZwUzZRasEES1sBPda2zkiwvWH6HmpU5fpxYo5Jegrtv V1hTDBcBGnD20f2Jv36nkO1rTJBRyLKI76A5BUZJvwNk6C3hNfG0WOq+UBmLRq/m f8TVtca4souGWqy7PtSn0LkmwZ/k9MMhBzePgHLkg8XIRHRpTQ+t9BlPbu8VrHqX ieNalV4YuK3A0IikRddliyDio9OixCL372XCO+ViD3zepLizcWiZJHYiNXN8ZdIO +FQrU5hAgvdwSAiBxVN8VorcyXjuvWA9PAwHtoL4EUKqmesxN1wJMdbJvMuO+3GJ GeZPvA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4asfu12dqp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Dec 2025 07:55:36 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7bebc19afd5so1001886b3a.0 for ; Mon, 01 Dec 2025 23:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764662136; x=1765266936; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wya6bVI7BEkGEtZdZUR36jM/nyPYy5oPLlPIXVCOb30=; b=b2kWoHXb9dTz1mj9SE/ID5oG2M9p+6IlJlBA7en3KOA9IyLZKIiygLITy1hAS9+1f6 lpzwrAIabyQV9+hJvqJ4WxoyYUG2lA9wIPUSd9Wq9O8/UHBbMmSkXW8nx7z6Skhe7+nX QGYcMPnTpMxtv36n4dCyEJXd5m8VDlPW4rWKFu5IkFj7ssIWFzxzJdl3GfyqR5qGe4Z6 AVpwFqp4rmsjZYHeStC6Il1ZvJx/65ABIK65uzgwTSZV57K4U6UBpkWFUX/LxaJHzeu0 dGYhV3rcb/wymAqIIfp/+PoUPCe7M3+lzTc/+2HQE8hyfVB8jQXDkJ8S/+lyJsvq7cQU /fUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764662136; x=1765266936; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wya6bVI7BEkGEtZdZUR36jM/nyPYy5oPLlPIXVCOb30=; b=iiksTNtXIaqlCzwMnVYpJ7cUoEdHDik8JglfCk5h07fg+LJ8KvAe3hnrT5hCGqztrv NgzjkUZa6TbsOwfPF1LAewBcuvtVp0pKVrhQfNpi4S7bSgcCdpf2kLE6Zc2fvxg2cVdJ nHS9Td1Vp4I5Sp6ASzqE8lA9VQe+6zImsa97gBbY0uPwTukw8b6euCfMOL8PgkJpGPxc lCbpM8vI9aQZWBOuEOutNiLBPUnsVGzxf2KR982hKs8j5RH/Zluz1dHYSo/AB5AY2a6x 2kwrcn2DCAtBqEV5LFnUpmQLMEmnmXBQQsYDachIiMVWkPR5uDprIINj902EDbxm8DQN 28gQ== X-Gm-Message-State: AOJu0YzmE/Mmt4NnuN52rmyqXJWsuYqNb4B0Dm5EEHY9/quL3Vb91XZw UoSz9lXXb7oY/L0Ck5hP08xodZiFMJwA+RJhQUHCbZRkAFgZ04lDQqcP41dESwt642JnPA04ojI 9ZJm3u+I8fFd+fsHzPj9U9KlYJrLqZw0SxJ1fl4bZkxL3KpsmcXOUeOEhfTGotUuaHM4= X-Gm-Gg: ASbGncvtLd0WXUUIFjjRXEICZz+piGdO25TahazzJA2VmCBZaEXwAEDcohmMFUHHRY/ rCjv/zR8B3RVeUlne9ABkPicndZgMgM9/niRnswgsF9W9ugJOuSRS0U/lWHfI/VgW090UztLN2I NJNAWxreExU5p7nsMPUP75O4csplD1jwe3TfIFlio7POYJnv8ynYHkqWAqvzF9NlyC6ZC3ErDhR hDdCYXm7RZD5Iu1XkAnjouc+qTULGEbx70Fln4hASKN+O+ig5CiowZmFdbeOQWlBmfv8Grfh5TP INu2T5GAC8BZc/oVV/T28sv6jREa0NyCvbqc9yYIC3Tl4U7OtsVbHAe4UvugL9MQaCT4OC9HyxS SNGs+FM5YlVqxh696IOfJ5YLnX1d7HWWfzDsznWI= X-Received: by 2002:a05:6a00:4616:b0:7ab:4c7e:a9db with SMTP id d2e1a72fcca58-7c58e015db7mr23192758b3a.4.1764662135813; Mon, 01 Dec 2025 23:55:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDagCqM24265L2wptqLWDdYstMbaqvH81mXy67wZVr269Rlhb4Lxee4n5gwW8t/c6a0UNIrg== X-Received: by 2002:a05:6a00:4616:b0:7ab:4c7e:a9db with SMTP id d2e1a72fcca58-7c58e015db7mr23192739b3a.4.1764662135348; Mon, 01 Dec 2025 23:55:35 -0800 (PST) Received: from [10.217.216.168] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d15fcfd0b6sm16045407b3a.64.2025.12.01.23.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 23:55:34 -0800 (PST) Message-ID: <4f3e5259-b84c-46aa-a744-5142b697f303@oss.qualcomm.com> Date: Tue, 2 Dec 2025 13:25:28 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 1/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_nguyenb@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sayalil@quicinc.com, quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com, kernel@oss.qualcomm.com References: <20251112071234.2570251-1-sarthak.garg@oss.qualcomm.com> <20251112071234.2570251-2-sarthak.garg@oss.qualcomm.com> <5887f8df-1cb4-48f7-a2c1-a13330d9dbda@oss.qualcomm.com> Content-Language: en-US From: Sarthak Garg In-Reply-To: <5887f8df-1cb4-48f7-a2c1-a13330d9dbda@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAyMDA2MiBTYWx0ZWRfX3OOdDCdCGFAM 3EblOBoUoBzaXwwAkroYebgse4b1yQzhyHxluXWxj6mADBYix/Pdt+OD7G6F+PxBHDDwqDW9ath 4B4mrdL2soXO8qPUQLncXdJZSlnNP5ym1urM7mEftzXRKa5w4KBUYHvtSVmFETX+WE/rvRrDx0G 7ahjfw2yTuPgAi9xMuHsqc61xYQtSNca1faHO8+xqnMgXJZs33C1VxgPmTtukaHo65wWdTXchly v7LMRG/dyVj+eXh4WSXUXH/B1r1wXWLvBG8raWXe5oZs17YobsVCLC0jDj4Y93W1uDGVsdy15T7 H2uGb7hCuOxHyrltOFid3b1xjha7783vIz+j6YRf47db2ymeaIPJ8JO1Ovwiceb1MidxMj6gyMk uMfh4ocjFn/P8MFgKhPdhwif0v2EUA== X-Authority-Analysis: v=2.4 cv=BJW+bVQG c=1 sm=1 tr=0 ts=692e9b78 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Z_JSJptOXzPKhhstl7EA:9 a=CffnxMIoaBPO8yaq:21 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: A6yA5u8jk3lJOe0zTvKrP_T2-XLkvKKc X-Proofpoint-ORIG-GUID: A6yA5u8jk3lJOe0zTvKrP_T2-XLkvKKc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512020062 On 11/18/2025 4:33 PM, Konrad Dybcio wrote: > On 11/12/25 8:12 AM, Sarthak Garg wrote: >> Add SD Card host controller for sm8750 soc. >> >> Signed-off-by: Sarthak Garg >> --- >> arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi >> index 3f0b57f428bb..ba8c010226e1 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi >> @@ -2582,6 +2582,60 @@ data-pins { >> }; >> }; >> >> + sdhc_2: mmc@8804000 { >> + compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5"; >> + reg = <0x0 0x08804000 0x0 0x1000>; >> + >> + interrupts = , >> + ; >> + interrupt-names = "hc_irq", >> + "pwr_irq"; >> + >> + clocks = <&gcc GCC_SDCC2_AHB_CLK>, >> + <&gcc GCC_SDCC2_APPS_CLK>, >> + <&rpmhcc RPMH_CXO_CLK>; >> + clock-names = "iface", >> + "core", >> + "xo"; >> + >> + interconnects = <&aggre2_noc MASTER_SDCC_2 QCOM_ICC_TAG_ALWAYS >> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, >> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY >> + &config_noc SLAVE_SDCC_2 QCOM_ICC_TAG_ACTIVE_ONLY>; > Nit: the '&'s look better when they're aligned to the previous line > > Reviewed-by: Konrad Dybcio > > Konrad Sure will update in V6. Regards, Sarthak