From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>
Cc: Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH v4 02/42] drm/msm/dpu: Allow variable SSPP_BLK size
Date: Wed, 5 Apr 2023 03:35:35 +0300 [thread overview]
Message-ID: <4fa6cbad-4daa-e030-9d41-4f9caa2d8a28@linaro.org> (raw)
In-Reply-To: <72915d9e-dbba-7391-28d8-cbbca479da76@quicinc.com>
On 05/04/2023 01:19, Abhinav Kumar wrote:
>
>
> On 4/4/2023 6:05 AM, Dmitry Baryshkov wrote:
>> From: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> These blocks are of variable length on different SoCs. Set the
>> correct values where I was able to retrieve it from downstream
>> DTs and leave the old defaults (0x1c8) otherwise.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> [DB: fixed some of lengths, split the INTF changes away]
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Everything is fine except sm8450. As I already wrote in the previous
> version's review, it should be 0x32c for sm8450.
>
Ack, please excuse me for missing you comment. I'll fix this in v5.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-04-05 0:35 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 13:05 [PATCH v4 00/42] drm/msm/dpu: rework HW catalog Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 01/42] drm/msm/dpu: use CTL_SC7280_MASK for sm8450's ctl_0 Dmitry Baryshkov
2023-04-04 22:12 ` Abhinav Kumar
2023-04-05 0:33 ` Dmitry Baryshkov
2023-04-05 0:39 ` Abhinav Kumar
2023-04-05 0:43 ` Dmitry Baryshkov
2023-04-05 1:00 ` Abhinav Kumar
2023-04-05 1:17 ` Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 02/42] drm/msm/dpu: Allow variable SSPP_BLK size Dmitry Baryshkov
2023-04-04 22:19 ` Abhinav Kumar
2023-04-05 0:35 ` Dmitry Baryshkov [this message]
2023-04-04 13:05 ` [PATCH v4 03/42] drm/msm/dpu: Allow variable INTF_BLK size Dmitry Baryshkov
2023-04-04 22:30 ` Abhinav Kumar
2023-04-05 0:37 ` Dmitry Baryshkov
2023-04-05 1:02 ` Abhinav Kumar
2023-04-04 13:05 ` [PATCH v4 04/42] drm/msm/dpu: constify DSC data structures Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 05/42] drm/msm/dpu: mark remaining pp data as const Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 06/42] drm/msm/dpu: move UBWC/memory configuration to separate struct Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 07/42] drm/msm/dpu: split SM8550 catalog entry to the separate file Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 08/42] drm/msm/dpu: split SM8450 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 09/42] drm/msm/dpu: split SC8280XP " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 10/42] drm/msm/dpu: split SC7280 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 11/42] drm/msm/dpu: split SM8350 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 12/42] drm/msm/dpu: split SM6115 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 13/42] drm/msm/dpu: split QCM2290 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 14/42] drm/msm/dpu: split SC7180 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 15/42] drm/msm/dpu: split SM8250 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 16/42] drm/msm/dpu: split SC8180X " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 17/42] drm/msm/dpu: split SM8150 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 18/42] drm/msm/dpu: split MSM8998 " Dmitry Baryshkov
2023-04-04 13:05 ` [PATCH v4 19/42] drm/msm/dpu: split SDM845 " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 20/42] drm/msm/dpu: duplicate sdm845 catalog entries Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 21/42] drm/msm/dpu: duplicate sc7180 " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 22/42] drm/msm/dpu: duplicate sm8150 " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 23/42] drm/msm/dpu: duplicate sm8250 " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 24/42] drm/msm/dpu: duplicate sm8350 " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 25/42] drm/msm/dpu: expand sc8180x catalog Dmitry Baryshkov
2023-04-04 22:51 ` Abhinav Kumar
2023-04-04 13:06 ` [PATCH v4 26/42] drm/msm/dpu: expand sc7180 catalog Dmitry Baryshkov
2023-04-04 23:06 ` Abhinav Kumar
2023-04-04 13:06 ` [PATCH v4 27/42] drm/msm/dpu: expand sm6115 catalog Dmitry Baryshkov
2023-04-05 1:08 ` Abhinav Kumar
2023-04-04 13:06 ` [PATCH v4 28/42] drm/msm/dpu: expand sm8550 catalog Dmitry Baryshkov
2023-04-05 1:12 ` Abhinav Kumar
2023-04-04 13:06 ` [PATCH v4 29/42] drm/msm/dpu: use defined symbol for sc8280xp's maxwidth Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 30/42] drm/msm/dpu: catalog: add comments regarding DPU_CTL_SPLIT_DISPLAY Dmitry Baryshkov
2023-04-05 1:29 ` Abhinav Kumar
2023-04-04 13:06 ` [PATCH v4 31/42] drm/msm/dpu: enable DPU_CTL_SPLIT_DISPLAY for sc8280xp Dmitry Baryshkov
2023-04-05 1:34 ` Abhinav Kumar
2023-04-04 13:06 ` [PATCH v4 32/42] drm/msm/dpu: enable DSPP_2/3 for LM_2/3 on sm8450 Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 33/42] drm/msm/dpu: drop duplicate vig_sblk instances Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 34/42] drm/msm/dpu: enable DSPP and DSC on sc8180x Dmitry Baryshkov
2023-04-07 23:43 ` Abhinav Kumar
2023-04-08 0:08 ` Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 35/42] drm/msm/dpu: inline IRQ_n_MASK defines Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 36/42] drm/msm/dpu: rename INTF_foo_MASK to contain major DPU version Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 37/42] drm/msm/dpu: rename CTL_foo_MASK " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 38/42] drm/msm/dpu: rename VIG and DMA_foo_MASK " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 39/42] drm/msm/dpu: rename MIXER_foo_MASK " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 40/42] drm/msm/dpu: rename MERGE_3D_foo_MASK " Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 41/42] drm/msm/dpu: fetch DPU configuration from match data Dmitry Baryshkov
2023-04-04 13:06 ` [PATCH v4 42/42] drm/msm/dpu: drop unused macros from hw catalog Dmitry Baryshkov
2023-04-08 0:19 ` [PATCH v4 00/42] drm/msm/dpu: rework HW catalog Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fa6cbad-4daa-e030-9d41-4f9caa2d8a28@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).