From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A7A3C761A6 for ; Wed, 5 Apr 2023 15:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239057AbjDEPrb (ORCPT ); Wed, 5 Apr 2023 11:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239048AbjDEPr3 (ORCPT ); Wed, 5 Apr 2023 11:47:29 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA2F340DA for ; Wed, 5 Apr 2023 08:47:01 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id y7so5328750ljp.2 for ; Wed, 05 Apr 2023 08:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680709617; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dxSZTYnDcq5s93QjGt0L3XgCVNV0CavkH4ScS09zEU8=; b=xmb9RSub4xOC3+mtoNF99fZ6KiHrpV6FrYFEALIIG0bYj1LKC7/mqZg9F9a6rnqsNX Ha5rht9rzSAvwtTbiRg35h2tGPRgWH/9K6YyN3tDojfpBMi/XhKwiW8pyZrMcqHO6GI7 eGGJRe+atnga41rSRnRd29rbg/+N0DtPowse9SH+j1zrARQ1vkz6h4pZDt1tl+SyFNhW vqpN3V/H2+HcDhZ74UqWm+sJ3I6KAcLovNLJuqf+COCHb/LpaEpXtOvtzP5HexzKstm0 Pl1he+1oK9i9x0A8frK7bV0Ix6SFwXyNhct3lKNM9iioRRWS8Xahq0IgJhFtdZA2P0o5 qL0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680709617; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dxSZTYnDcq5s93QjGt0L3XgCVNV0CavkH4ScS09zEU8=; b=3qupd8O0ZpLocvjex6t3rrkxqs1jY27WnyA7FB4AMC4H1kx7w7qCfPSkVu78+k8d/z Hz8k7vsKCv0i5VTL7boi97DLqKosZEnZFYpSgnA7CTWqKcB4MQptttFUqLMNNTuMRZYB 52ayjWYWj72iuQK6/vuQXC21gVUyMG0k1kfpWbXP5+hzmUfcgpLG6qwMM83ua0BqTfwK ie61A9i0dPimdkACOsrew92IvELcrrLz7M8MPqlh+lFzpew5Ji7AZYOQOAUbX2qMPPZz kjNl4f8zdDawlLW5IvS6RsaC8llsPEpHAP1byUFuy22uxjq7ZPCaf7YYyHlV9Dx9IFPm jxUA== X-Gm-Message-State: AAQBX9eCn+5K11h46L8QSUGwt/NBL/lWlLF9xJw+nniC1eFTGX//plFE anEMe50a4n7hntPGrlHgp8BZVA== X-Google-Smtp-Source: AKy350YnAa/sHazifyT3J9hcsEFG1SqVCFTYFoilpzg/MpP/TjDc1+ftvez2CGD5umA6Eq+UEcNEYg== X-Received: by 2002:a2e:9bd8:0:b0:2a6:23ac:4e70 with SMTP id w24-20020a2e9bd8000000b002a623ac4e70mr2383740ljj.14.1680709616858; Wed, 05 Apr 2023 08:46:56 -0700 (PDT) Received: from [192.168.1.101] (abxh37.neoplus.adsl.tpnet.pl. [83.9.1.37]) by smtp.gmail.com with ESMTPSA id i19-20020a2e8093000000b0029f3e2efbb9sm2905499ljg.90.2023.04.05.08.46.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 08:46:56 -0700 (PDT) Message-ID: <4feaadbe-966d-0c2a-d502-e758194bba5f@linaro.org> Date: Wed, 5 Apr 2023 17:46:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/5] arm64: dts: qcom: sc8280xp: label the Soundwire nodes Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230405060906.143058-1-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20230405060906.143058-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5.04.2023 08:09, Krzysztof Kozlowski wrote: > Use labels, instead of comments, for Soundwire controllers. Naming them > is useful, because they are specialized and have also naming in > datasheet/programming guide. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index cd38320dafda..c195a57fd180 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -2497,7 +2497,6 @@ rxmacro: rxmacro@3200000 { > status = "disabled"; > }; > > - /* RX */ > swr1: soundwire-controller@3210000 { > compatible = "qcom,soundwire-v1.6.0"; > reg = <0 0x03210000 0 0x2000>; > @@ -2572,13 +2571,13 @@ wsamacro: codec@3240000 { > status = "disabled"; > }; > > - /* WSA */ > swr0: soundwire-controller@3250000 { > reg = <0 0x03250000 0 0x2000>; > compatible = "qcom,soundwire-v1.6.0"; > interrupts = ; > clocks = <&wsamacro>; > clock-names = "iface"; > + label = "WSA"; > > qcom,din-ports = <2>; > qcom,dout-ports = <6>; > @@ -2600,7 +2599,6 @@ swr0: soundwire-controller@3250000 { > status = "disabled"; > }; > > - /* TX */ > swr2: soundwire-controller@3330000 { > compatible = "qcom,soundwire-v1.6.0"; > reg = <0 0x03330000 0 0x2000>;