Re: [PATCH v11 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/06/2025 09:23, George Moussalem wrote:
>>>>
>>>>
>>>>>    1 file changed, 4 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>>>> index 0e653bbe9884953b58c4d8569b8d096db47fd54f..73d722bda8adc2c930edfc3373e6011f19c7c491 100644
>>>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>>>> @@ -36,10 +36,13 @@ properties:
>>>>>                  - qcom,msm8974-tsens
>>>>>              - const: qcom,tsens-v0_1
>>>>>    
>>>>> +      - description: v1 of TSENS
>>>>
>>>> So that's still v1... I don't understand.
>>>
>>> As mentioned, the IP is still v1 but with a different init routine in
>>> the driver for IP v1 without RPM
>>
>> OK, just merge it into first enum and drop the description there.
> 
> can't merge it into the first enum as that description is invalid for 
> this SoC ("description: msm8960 TSENS based").

That is why I asked to drop the description there.

> 
> My proposal would be:
> 
>        - description: v1 of TSENS
>          oneOf:
>            - enum: # for IP V1 without RPM
>                - qcom,ipq5018-tsens
>            - items:
>                - enum:
>                    - qcom,msm8937-tsens
>                    - qcom,msm8956-tsens
>                    - qcom,msm8976-tsens
>                    - qcom,qcs404-tsens
>                - const: qcom,tsens-v1

No double nesting. That's already oneOf at the top. Anyway, not
important, so fine if you want to keep it like in this patch, but add
detailed description.

Best regards,
Krzysztof