From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Mukesh Ojha <quic_mojha@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Stephan Gerhold <stephan.gerhold@linaro.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Kuldeep Singh <quic_kuldsing@quicinc.com>,
Elliot Berman <quic_eberman@quicinc.com>,
Andrew Halaney <ahalaney@redhat.com>,
Avaneesh Kumar Dwivedi <quic_akdwived@quicinc.com>,
Andy Gross <andy.gross@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC/RFT 4/6] firmware: qcom: scm: Cleanup global '__scm' on probe failures
Date: Thu, 28 Nov 2024 21:25:25 +0100 [thread overview]
Message-ID: <503df6db-8937-4e1c-9c0e-0cc093681a8b@oss.qualcomm.com> (raw)
In-Reply-To: <3bfd6343-de4a-4cf5-a4b8-55a3531eb41e@linaro.org>
On 19.11.2024 8:37 PM, Krzysztof Kozlowski wrote:
> On 19/11/2024 19:33, Krzysztof Kozlowski wrote:
>> /*
>> * Initialize the QSEECOM interface.
>> @@ -2094,6 +2104,12 @@ static int qcom_scm_probe(struct platform_device *pdev)
>> WARN(ret < 0, "failed to initialize qseecom: %d\n", ret);
>>
>> return 0;
>> +
>> +err:
>> + /* Paired with smp_load_acquire() in qcom_scm_is_available(). */
>> + smp_store_release(&__scm, 0);
> Heh, I should store there NULL, obviously.
Candidate for a new scoped __free, perhaps?
Konrad
next prev parent reply other threads:[~2024-11-28 20:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 18:33 [PATCH 0/6] firmware: qcom: scm: Fixes for concurrency Krzysztof Kozlowski
2024-11-19 18:33 ` [PATCH 1/6] firmware: qcom: scm: Fix missing read barrier in qcom_scm_is_available() Krzysztof Kozlowski
2024-11-20 10:51 ` Bartosz Golaszewski
2024-11-19 18:33 ` [PATCH 2/6] firmware: qcom: scm: Fix missing read barrier in qcom_scm_get_tzmem_pool() Krzysztof Kozlowski
2024-11-19 18:45 ` Krzysztof Kozlowski
2024-11-19 18:33 ` [PATCH 3/6] firmware: qcom: scm: Handle various probe ordering for qcom_scm_assign_mem() Krzysztof Kozlowski
2024-11-20 14:07 ` Bartosz Golaszewski
2024-11-20 14:19 ` Krzysztof Kozlowski
2024-11-20 14:21 ` Krzysztof Kozlowski
2024-11-27 4:45 ` Bjorn Andersson
2024-11-19 18:33 ` [PATCH RFC/RFT 4/6] firmware: qcom: scm: Cleanup global '__scm' on probe failures Krzysztof Kozlowski
2024-11-19 19:37 ` Krzysztof Kozlowski
2024-11-28 20:25 ` Konrad Dybcio [this message]
2024-11-19 18:33 ` [PATCH 5/6] firmware: qcom: scm: smc: Handle missing SCM device Krzysztof Kozlowski
2024-11-19 18:33 ` [PATCH 6/6] firmware: qcom: scm: smc: Narrow 'mempool' variable scope Krzysztof Kozlowski
2024-11-20 11:06 ` Bartosz Golaszewski
2024-11-20 11:13 ` [PATCH 0/6] firmware: qcom: scm: Fixes for concurrency Dmitry Baryshkov
2024-11-20 16:20 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503df6db-8937-4e1c-9c0e-0cc093681a8b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_akdwived@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_kuldsing@quicinc.com \
--cc=quic_mojha@quicinc.com \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox