From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP
Date: Wed, 2 Jul 2025 22:33:50 +0200 [thread overview]
Message-ID: <507205ff-fdb8-4f43-ab69-418cfd9da4af@kernel.org> (raw)
In-Reply-To: <DB0N2N5JIUNS.3UFD0C81VYS9F@fairphone.com>
On 01/07/2025 12:16, Luca Weiss wrote:
>>> - if:
>>> properties:
>>> compatible:
>>> @@ -185,6 +205,7 @@ allOf:
>>> compatible:
>>> contains:
>>> enum:
>>> + - qcom,sm7635-adsp-pas
>>> - qcom,sm8550-adsp-pas
>>> - qcom,sm8650-adsp-pas
>>> - qcom,sm8750-adsp-pas
>>
>> sm6350 fits, doesn't it?
>
> Not quite, for sure the firmware-name and memory-region for adsp and
> cdsp on this SoC requires the dtb firmware file as well, apart from that
> it looks similar enough.
I looked briefly, so indeed it might not fit well. That's on you to
investigate and find the best candidate which will mean the least amount
of changes or the simplest binding.
>
> I'm also okay with creating a new (after the whole renaming thing)
> qcom,milos-pas.yaml which contains the bindings for all 4 *-pas'es.
If it does not fit sm6350 or others then yes, new binding it is.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-02 20:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 6:55 [PATCH v2 0/3] Add support for remoteprocs on SM7635 Luca Weiss
2025-06-27 6:55 ` [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS Luca Weiss
2025-07-01 8:12 ` Krzysztof Kozlowski
2025-07-01 10:12 ` Luca Weiss
2025-07-02 20:32 ` Krzysztof Kozlowski
2025-06-27 6:55 ` [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP Luca Weiss
2025-07-01 8:14 ` Krzysztof Kozlowski
2025-07-01 10:16 ` Luca Weiss
2025-07-02 20:33 ` Krzysztof Kozlowski [this message]
2025-06-27 6:55 ` [PATCH v2 3/3] remoteproc: qcom: pas: Add SM7635 remoteproc support Luca Weiss
2025-07-01 12:13 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507205ff-fdb8-4f43-ab69-418cfd9da4af@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).