From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rong Zhang <i@rong.moe>, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>
Subject: Re: [PATCH v2 1/4] ARM: dts: qcom: msm8974: Split out common part of samsung-klte
Date: Mon, 29 Jan 2024 09:22:23 +0100 [thread overview]
Message-ID: <509ef748-80e7-490b-a096-80c942eba92d@linaro.org> (raw)
In-Reply-To: <20240127172155.63624-2-i@rong.moe>
On 27/01/2024 18:21, Rong Zhang wrote:
> Samsung Galaxy S5 has many variants. Variants that support LTE use klte*
> as their codename. Currently, the only supported one is the one without
> any suffix, namely, klte. It is known that other klte* variants have
> only minor differences compared to klte and can mostly work with the
> klte DTB.
>
> Split the common part into a common DTSI so that it can be imported in
> the DTS of klte and other klte* variants.
>
> Signed-off-by: Rong Zhang <i@rong.moe>
> ---
> .../qcom-msm8974pro-samsung-klte-common.dtsi | 812 +++++++++++++++++
> .../dts/qcom/qcom-msm8974pro-samsung-klte.dts | 813 +-----------------
> 2 files changed, 818 insertions(+), 807 deletions(-)
Why code move is not detected? It's difficult to review it. You moved
almost 100% of lines. Please use correct -B/-M/-C arguments when
generating patch and create new one with proper code move.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-29 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 17:21 [PATCH v2 0/4] ARM: dts: qcom: msm8974: Add Samsung Galaxy S5 China support Rong Zhang
2024-01-27 17:21 ` [PATCH v2 1/4] ARM: dts: qcom: msm8974: Split out common part of samsung-klte Rong Zhang
2024-01-29 8:22 ` Krzysztof Kozlowski [this message]
2024-01-29 9:02 ` Rong Zhang
2024-01-27 17:21 ` [PATCH v2 2/4] ARM: dts: qcom: msm8974-klte-common: Pin WiFi board type Rong Zhang
2024-01-27 17:21 ` [PATCH v2 3/4] dt-bindings: arm: qcom: Add Samsung Galaxy S5 China (kltechn) Rong Zhang
2024-01-29 8:20 ` Krzysztof Kozlowski
2024-01-29 8:40 ` Rong Zhang
2024-01-27 17:21 ` [PATCH v2 4/4] ARM: dts: qcom: msm8974: Add DTS for " Rong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509ef748-80e7-490b-a096-80c942eba92d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=i@rong.moe \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).