From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>,
lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space
Date: Sun, 7 Jul 2024 14:46:59 +0200 [thread overview]
Message-ID: <50d0bdd6-2262-4404-9a26-29b1f2e6fe92@kernel.org> (raw)
In-Reply-To: <20240705153252.1571814-2-quic_mojha@quicinc.com>
On 05/07/2024 17:32, Mukesh Ojha wrote:
> Enable download mode for sa8775p which can help collect
> ramdump for this SoC.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 23f1b2e5e624..a46d00b1ddda 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -221,6 +221,7 @@ eud_in: endpoint {
> firmware {
> scm {
> compatible = "qcom,scm-sa8775p", "qcom,scm";
> + qcom,dload-mode = <&tcsr 0x13000>;
> memory-region = <&tz_ffi_mem>;
> };
> };
> @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
> #hwlock-cells = <1>;
> };
>
> + tcsr: syscon@1fc0000 {
> + compatible = "qcom,sa8775p-tcsr", "syscon";
The file is going away. This change is very confusing.
Please align first with your colleagues instead of sending conflicting
work without any explanation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-07 12:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 15:32 [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Mukesh Ojha
2024-07-05 15:32 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space Mukesh Ojha
2024-07-05 18:30 ` Elliot Berman
2024-07-07 12:46 ` Krzysztof Kozlowski [this message]
2024-07-08 16:08 ` Mukesh Ojha
2024-07-29 10:50 ` Tengfei Fan
2024-07-05 18:21 ` [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Elliot Berman
2024-07-07 12:46 ` Krzysztof Kozlowski
2024-07-29 10:48 ` Tengfei Fan
2024-08-27 16:04 ` Mukesh Ojha
2024-08-27 17:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50d0bdd6-2262-4404-9a26-29b1f2e6fe92@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox