From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80014C32751 for ; Wed, 31 Jul 2019 14:11:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 572BC208E4 for ; Wed, 31 Jul 2019 14:11:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pn45YGzO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729121AbfGaOLF (ORCPT ); Wed, 31 Jul 2019 10:11:05 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50446 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729138AbfGaOLF (ORCPT ); Wed, 31 Jul 2019 10:11:05 -0400 Received: by mail-wm1-f66.google.com with SMTP id v15so61006312wml.0 for ; Wed, 31 Jul 2019 07:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DaSfQVSBloP6ituQwd3gN2sNQYfvnC2s71RqutisBq0=; b=Pn45YGzOCoqVPj5ruMllJckodlhVBmgzWrH3x/e0USvGBmmg4/Ju4GVTO3/dRSpBTY 576PmDDVUKYSxfaA1m94qhQ8UbmUNa4NfL1mXsG4Cq5I/yz4KkQozkzA+tTJ5oyrS9a5 wahvQMETUJkBFk2+TS9+O3vcsd4sB1rUI5rgIBWJvS6kGoYyzNBRtoOh/brUuKjLVgqb lJkOws6k7U0nPUeGV0XD+Cc9eDsiWdIXbue+NdiSajyLETAOv5J2/b38B0MNu0VMg1ss pRO70fcoPMvX0eHH4aQKvcl9z9u4yPd3QOFBhz23Zxc8o6UX+WAxo7JKNb4ZvLBDrnWr m9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DaSfQVSBloP6ituQwd3gN2sNQYfvnC2s71RqutisBq0=; b=mVDOiz9VGMg7/kwTa4fQS//7U7vYOCeA75qHPrlpDcbed8ztpNJRlZaid9VaISgmeW 8o5Ae22gUE5Ej4NDDIWiwIKPN17vAyNCxlB8MRr6INJMDDmiIQfkGrBWsHy0iS9A5UWP XwehH+Smgc0QG6tI6uKXK4D6orusTncx/RM566p/2d0h0yfOUU47MvPyMVic78FSAtMT s9QIIXlaeh+O1TvOJtEL4f6QSLY4XZzMeHUBMZdgVz5fJTaR+gg0KQupos+F+xlOq/Se 7Iro5eXd5t6mmrY/LmjK9rqu87BzvK7SjNUkdt0yajMqjfXHYE6vRftOlkBAzntr8IGN GtPA== X-Gm-Message-State: APjAAAXhRF+HN0OHmCijAICi2pkwWfhG4rPMb8/7oQDmgCDr/4eCgmm3 4BLzizSEGUK3AUZ+NX8KDhIANw== X-Google-Smtp-Source: APXvYqw/pUX7GShISMzCbUQtESxSOCGVNvngtydQFUT3NN7ACbQtiRIRf1AbgIrVwpXKDn1FZaNSkQ== X-Received: by 2002:a05:600c:34d:: with SMTP id u13mr85321496wmd.48.1564582262533; Wed, 31 Jul 2019 07:11:02 -0700 (PDT) Received: from [192.168.1.6] (19.red-176-86-136.dynamicip.rima-tde.net. [176.86.136.19]) by smtp.gmail.com with ESMTPSA id a81sm71773684wmh.3.2019.07.31.07.11.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jul 2019 07:11:01 -0700 (PDT) Subject: Re: [PATCH v3 02/14] mbox: qcom: add APCS child device for QCS404 To: Bjorn Andersson Cc: sboyd@kernel.org, david.brown@linaro.org, jassisinghbrar@gmail.com, mark.rutland@arm.com, mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com, arnd@arndb.de, horms+renesas@verge.net.au, heiko@sntech.de, sibis@codeaurora.org, enric.balletbo@collabora.com, jagan@amarulasolutions.com, olof@lixom.net, vkoul@kernel.org, niklas.cassel@linaro.org, georgi.djakov@linaro.org, amit.kucheria@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, khasim.mohammed@linaro.org References: <20190625164733.11091-1-jorge.ramirez-ortiz@linaro.org> <20190625164733.11091-3-jorge.ramirez-ortiz@linaro.org> <20190711144424.GD7234@tuxbook-pro> From: Jorge Ramirez Message-ID: <5111bc6e-4155-e99e-71b2-1aac3610b71e@linaro.org> Date: Wed, 31 Jul 2019 16:10:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190711144424.GD7234@tuxbook-pro> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 7/11/19 16:44, Bjorn Andersson wrote: > On Tue 25 Jun 09:47 PDT 2019, Jorge Ramirez-Ortiz wrote: > >> There is clock controller functionality in the APCS hardware block of >> qcs404 devices similar to msm8916. >> >> Co-developed-by: Niklas Cassel >> Signed-off-by: Niklas Cassel >> Signed-off-by: Jorge Ramirez-Ortiz >> --- >> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 18 ++++++++++-------- >> 1 file changed, 10 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> index 705e17a5479c..a05dc3aabac7 100644 >> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> @@ -89,16 +89,18 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) >> return ret; >> } >> >> - if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) { >> - apcs->clk = platform_device_register_data(&pdev->dev, >> - "qcom-apcs-msm8916-clk", >> - -1, NULL, 0); >> - if (IS_ERR(apcs->clk)) >> - dev_err(&pdev->dev, "failed to register APCS clk\n"); >> - } >> - >> platform_set_drvdata(pdev, apcs); >> >> + if (!of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global") && >> + !of_device_is_compatible(np, "qcom,qcs404-apcs-apps-global")) > > If the remainder of the function was a long snippet I think this would > motivate the somewhat unusual early return. But I think it would be > cleaner to just add to the existing conditional. sure can do that. I dont agree (I wouldnt have bothered otherwise :)) but will do > > Regards, > Bjorn > >> + return 0; >> + >> + apcs->clk = platform_device_register_data(&pdev->dev, >> + "qcom-apcs-msm8916-clk", >> + -1, NULL, 0); >> + if (IS_ERR(apcs->clk)) >> + dev_err(&pdev->dev, "failed to register APCS clk\n"); >> + >> return 0; >> } >> >> -- >> 2.21.0 >> >