From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey Hugo Subject: Re: [PATCH] regulator: qcom-smd: Batch up requests for disabled regulators Date: Tue, 22 Jan 2019 14:57:46 -0700 Message-ID: <5165f4d3-5c98-86de-4813-589e1e3da3d8@codeaurora.org> References: <20190122190147.26735-1-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190122190147.26735-1-bjorn.andersson@linaro.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 1/22/2019 12:01 PM, Bjorn Andersson wrote: > In some scenarios the early stages of the boot chain has configured > regulators to be in a required state, but the later stages has skipped > to inform the RPM about it's requirements. > > But as the SMD RPM regulators are being initialized voltage change > requests will be issued to align the voltage with the valid ranges. The > RPM aggregates all parameters for the specific regulator, the voltage > will be adjusted and the "enabled" state will be "off" - and the > regulator is turned off. > > This patch addresses this problem by caching the requested enable state, > voltage and load and send the parameters in a batch, depending on the > enable state - effectively delaying the voltage request for disabled > regulators. > > Signed-off-by: Bjorn Andersson This happens to fix an annoyance I've been avoiding on 8998. Reviewed-by: Jeffrey Hugo Tested-by: Jeffrey Hugo -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.