From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rohit Vaswani Subject: Re: [PATCHv2 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2 Date: Fri, 31 May 2013 14:31:59 -0700 Message-ID: <51A916CF.1070107@codeaurora.org> References: <1369268964-28304-1-git-send-email-rvaswani@codeaurora.org> <1369268964-28304-4-git-send-email-rvaswani@codeaurora.org> <20130531124256.D269C3E0901@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130531124256.D269C3E0901@localhost> Sender: linux-doc-owner@vger.kernel.org To: Grant Likely Cc: Linus Walleij , Rob Herring , Rob Landley , Russell King , David Brown , Bryan Huntsman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 5/31/2013 5:42 AM, Grant Likely wrote: > On Wed, 22 May 2013 17:29:24 -0700, Rohit Vaswani wrote: >> This cleans up the gpio-msm-v2 driver of all the global define usage. >> The number of gpios are now defined in the device tree. This enables >> adding irqdomain support as well. >> >> Signed-off-by: Rohit Vaswani > Hi Rohit, > > Comments below on this driver... Thanks Grant for your comments. Have addressed some of these in v3. Will fix the bitmap allocation and other comments in v4. Thanks, Rohit Vaswani -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation