From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Sarannya S <quic_sarannya@quicinc.com>,
<quic_bjorande@quicinc.com>, <arnaud.pouliquen@foss.st.com>,
<swboyd@chromium.org>, <quic_clew@quicinc.com>,
<mathieu.poirier@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>
Subject: Re: [PATCH V6 0/3] rpmsg signaling/flowcontrol patches
Date: Thu, 20 Apr 2023 12:42:24 +0530 [thread overview]
Message-ID: <52028f1a-e7f4-0ffe-e359-d95fbbc86cf0@quicinc.com> (raw)
In-Reply-To: <1681971690-28858-1-git-send-email-quic_sarannya@quicinc.com>
On 4/20/2023 11:51 AM, Sarannya S wrote:
> Added new IOCTLS- RPMSG_GET_OUTGOING_FLOWCONTROL and RPMSG_SET_INCOMING_FLOWCONTROL
> to get/set the rpmsg char device's flow control signal.
> Updated the cmd name 'RPM_CMD_SIGNALS' to 'GLINK_CMD_SIGNALS'.
> Changed 'remote_flow' to bool type, and updated it's evaluation.
> Updated evaluation of 'set' in rpmsg_char as 'set = !!arg'.
> Add destination address of endpoint as parameter in rpmsg_set_flow_control.
> Addressed review comments to change variable names/descriptions.
Something to notice, you are not changing the version number as you have
sent v6 here again.
Also maintain the changes happened from the last patch series properly.
Like
Changes in v6:
- ..
- ..
Change in v5: (a lore kernel link will be helpful here for reviewer to
remind the conversation happened during last review)
- ..
- ..
--Mukesh
>
> Chris Lew (2):
> rpmsg: glink: Add support to handle signals command
> rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support
>
> Deepak Kumar Singh (1):
> rpmsg: core: Add signal API support
>
> drivers/rpmsg/qcom_glink_native.c | 64 +++++++++++++++++++++++++++++++++++++++
> drivers/rpmsg/rpmsg_char.c | 49 ++++++++++++++++++++++++++----
> drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 2 ++
> include/linux/rpmsg.h | 15 +++++++++
> include/uapi/linux/rpmsg.h | 11 ++++++-
> 6 files changed, 155 insertions(+), 7 deletions(-)
>
next prev parent reply other threads:[~2023-04-20 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 6:21 [PATCH V6 0/3] rpmsg signaling/flowcontrol patches Sarannya S
2023-04-20 6:21 ` [PATCH V6 1/3] rpmsg: core: Add signal API support Sarannya S
2023-04-20 6:21 ` [PATCH V6 2/3] rpmsg: glink: Add support to handle signals command Sarannya S
2023-04-20 6:21 ` [PATCH V6 3/3] rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support Sarannya S
2023-04-20 18:38 ` Bjorn Andersson
2023-04-20 7:10 ` [PATCH V6 0/3] rpmsg signaling/flowcontrol patches Arnaud POULIQUEN
2023-04-20 7:12 ` Mukesh Ojha [this message]
2023-04-20 15:41 ` Mathieu Poirier
-- strict thread matches above, loose matches on Subject: below --
2023-04-19 13:53 Sarannya S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52028f1a-e7f4-0ffe-e359-d95fbbc86cf0@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=arnaud.pouliquen@foss.st.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_clew@quicinc.com \
--cc=quic_sarannya@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox