From: Sujit Reddy Thumma <sthumma@codeaurora.org>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
Santosh Y <santoshsy@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] scsi: ufs: Allow vendor specific initialization
Date: Tue, 13 Aug 2013 19:42:28 +0530 [thread overview]
Message-ID: <520A3ECC.9040007@codeaurora.org> (raw)
In-Reply-To: <20130813135352.GE31772@joshc.qualcomm.com>
On 8/13/2013 7:23 PM, Josh Cartwright wrote:
> On Tue, Aug 13, 2013 at 04:30:18PM +0530, Sujit Reddy Thumma wrote:
> [..]
>> diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
>> index a823cf4..829f7a4 100644
>> --- a/drivers/scsi/ufs/ufshcd-pci.c
>> +++ b/drivers/scsi/ufs/ufshcd-pci.c
>> @@ -191,7 +191,13 @@ ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>> return err;
>> }
>>
>> - err = ufshcd_init(&pdev->dev, &hba, mmio_base, pdev->irq);
>> + err = ufshcd_alloc_host(&pdev->dev, &hba);
>> + if (err) {
>> + dev_err(&pdev->dev, "Allocation failed\n");
>> + goto out_iounmap
>
> You seem to be missing a semicolon here.
I should have compiled the with pci config enabled :)
>
> Also, which tree were these patches generated against? They fail to
> apply at least on the last few 3.11-rc's.
I have rebased on top of scsi-misc branch along with few UFS patches
that aren't merged ([PATCH 0/9] scsi:ufs: query, bkops support and
other fixes + [PATCH V5 0/4] scsi: ufs: Improve UFS error handling
patch series).
--
Regards,
Sujit
next prev parent reply other threads:[~2013-08-13 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 11:00 [PATCH 0/3] scsi: ufs: Add support for clock and regulator initializaiton Sujit Reddy Thumma
2013-08-13 11:00 ` [PATCH 1/3] scsi: ufs: Allow vendor specific initialization Sujit Reddy Thumma
2013-08-13 13:53 ` Josh Cartwright
2013-08-13 14:12 ` Sujit Reddy Thumma [this message]
2013-08-13 11:00 ` [PATCH 2/3] scsi: ufs: Add regulator enable support Sujit Reddy Thumma
2013-08-13 11:00 ` [PATCH 3/3] scsi: ufs: Add clock initialization support Sujit Reddy Thumma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A3ECC.9040007@codeaurora.org \
--to=sthumma@codeaurora.org \
--cc=JBottomley@parallels.com \
--cc=joshc@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).