From: Manu Gautam <mgautam@codeaurora.org>
To: Jack Pham <jackp@codeaurora.org>
Cc: balbi@ti.com, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org,
pheatwol@codeaurora.org
Subject: Re: [PATCH v1 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode
Date: Tue, 17 Sep 2013 16:47:05 +0530 [thread overview]
Message-ID: <52383A31.6080204@codeaurora.org> (raw)
In-Reply-To: <20130917004514.GA22750@usblab-sd-06.qualcomm.com>
On 9/17/2013 6:15 AM, Jack Pham wrote:
> Hi Manu,
>
> An intern working with us here (thanks Peter!) found a bug.
>
> On Mon, Sep 16, 2013 at 03:10:14PM +0530, Manu Gautam wrote:
>> @@ -1569,7 +1573,20 @@ static int ffs_func_eps_enable(struct ffs_function *func)
>> spin_lock_irqsave(&func->ffs->eps_lock, flags);
>> do {
>> struct usb_endpoint_descriptor *ds;
>> - ds = ep->descs[ep->descs[1] ? 1 : 0];
>> + int desc_idx;
>> +
>> + if (ffs->gadget->speed == USB_SPEED_SUPER)
>> + desc_idx = 2;
>> + if (ffs->gadget->speed == USB_SPEED_HIGH)
> This should be "else if", otherwise if the gadget is superspeed, it will
> fall through to the full speed case below and desc_idx will be set to 0,
> resulting in FS descriptors being used instead.
Thanks. I will fix this in my next patch.
>> + desc_idx = 1;
>> + else
>> + desc_idx = 0;
>> +
>> + ds = ep->descs[desc_idx]
prev parent reply other threads:[~2013-09-17 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 9:40 [PATCH v1 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode Manu Gautam
[not found] ` <1379324414-7007-1-git-send-email-mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-09-17 0:45 ` Jack Pham
2013-09-17 11:17 ` Manu Gautam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52383A31.6080204@codeaurora.org \
--to=mgautam@codeaurora.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pheatwol@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).