From: Manu Gautam <mgautam@codeaurora.org>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: balbi@ti.com, jackp@codeaurora.org, pheatwol@codeaurora.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
benoit@android.com, andrzej.p@samsung.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v4 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode
Date: Tue, 24 Dec 2013 15:05:47 +0530 [thread overview]
Message-ID: <52B95573.7010806@codeaurora.org> (raw)
In-Reply-To: <xa1tbo07t10x.fsf@mina86.com>
On 12/24/2013 8:20 AM, Michal Nazarewicz wrote:
> On Mon, Dec 23 2013, Manu Gautam <mgautam@codeaurora.org> wrote:
>> Allow userspace to pass SuperSpeed descriptors and
>> handle them in the driver accordingly.
>> This change doesn't modify existing desc_header and thereby
>> keeps the ABI changes backward compatible i.e. existing
>> userspace drivers compiled with old header (functionfs.h)
>> would continue to work with the updated kernel.
>
> I'm mostly fine with this patch. If you change __ffs_func_bind_do_descs
> as I've described inline, feel free to resend with:
>
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
>
> The other two minor issues are up to you. I don't have strong feelings.
>
Thanks. I have tried to address your comments in ver-5 of the patch
that I just sent.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
prev parent reply other threads:[~2013-12-24 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 11:48 [PATCH v4 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode Manu Gautam
2013-12-23 17:00 ` Felipe Balbi
2013-12-24 2:50 ` Michal Nazarewicz
2013-12-24 9:35 ` Manu Gautam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B95573.7010806@codeaurora.org \
--to=mgautam@codeaurora.org \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=benoit@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=pheatwol@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).