From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manu Gautam Subject: Re: [PATCH v4 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode Date: Tue, 24 Dec 2013 15:05:47 +0530 Message-ID: <52B95573.7010806@codeaurora.org> References: <1387799322-26737-1-git-send-email-mgautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:50705 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434Ab3LXJfx (ORCPT ); Tue, 24 Dec 2013 04:35:53 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Michal Nazarewicz Cc: balbi@ti.com, jackp@codeaurora.org, pheatwol@codeaurora.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, benoit@android.com, andrzej.p@samsung.com, gregkh@linuxfoundation.org On 12/24/2013 8:20 AM, Michal Nazarewicz wrote: > On Mon, Dec 23 2013, Manu Gautam wrote: >> Allow userspace to pass SuperSpeed descriptors and >> handle them in the driver accordingly. >> This change doesn't modify existing desc_header and thereby >> keeps the ABI changes backward compatible i.e. existing >> userspace drivers compiled with old header (functionfs.h) >> would continue to work with the updated kernel. > > I'm mostly fine with this patch. If you change __ffs_func_bind_do_descs > as I've described inline, feel free to resend with: > > Acked-by: Michal Nazarewicz > > The other two minor issues are up to you. I don't have strong feelings. > Thanks. I have tried to address your comments in ver-5 of the patch that I just sent. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation