From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 4/7] mfd: ssbi: Add regmap read/write helpers Date: Mon, 06 Jan 2014 14:26:06 -0800 Message-ID: <52CB2D7E.7070505@codeaurora.org> References: <1387831563-13535-1-git-send-email-sboyd@codeaurora.org> <1387831563-13535-5-git-send-email-sboyd@codeaurora.org> <20131224125443.GC30815@sirena.org.uk> <20131226194133.GJ31766@codeaurora.org> <20140106115021.GC30156@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:47903 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756389AbaAFW0H (ORCPT ); Mon, 6 Jan 2014 17:26:07 -0500 In-Reply-To: <20140106115021.GC30156@lee--X1> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lee Jones Cc: Mark Brown , Samuel Ortiz , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 01/06/14 03:50, Lee Jones wrote: > On Thu, 26 Dec 2013, Stephen Boyd wrote: > >> On 12/24, Mark Brown wrote: >>> On Mon, Dec 23, 2013 at 12:46:00PM -0800, Stephen Boyd wrote: >>> >>>> +int ssbi_reg_read(void *context, unsigned int reg, unsigned int *val) >>>> +{ >>>> + *val = 0; >>>> + return ssbi_read(context, reg, (u8 *)val, 1); >>>> +} >>>> +EXPORT_SYMBOL_GPL(ssbi_reg_read); >>>> + >>>> +int ssbi_reg_write(void *context, unsigned int reg, unsigned int val) >>>> +{ >>>> + return ssbi_write(context, reg, (u8 *)&val, 1); >>>> +} >>>> +EXPORT_SYMBOL_GPL(ssbi_reg_write); >>> Not a big deal but could these just be inlined in the headers? >> Sure, I can do that if I need to resend? The only benefit I see >> is two less symbols exported. > Yes please. After this review. > Ok done. Just waiting for you to reply on patch 3 until I resend. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation