From: Christopher Covington <cov@codeaurora.org>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Felipe Balbi <balbi@ti.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP
Date: Fri, 17 Jan 2014 12:46:23 -0500 [thread overview]
Message-ID: <52D96C6F.7090608@codeaurora.org> (raw)
In-Reply-To: <1389979580-14812-1-git-send-email-joshc@codeaurora.org>
Hi Josh,
On 01/17/2014 12:26 PM, Josh Cartwright wrote:
[...]
> @@ -440,7 +414,32 @@ static int msm_otg_reset(struct usb_phy *phy)
> #define PHY_SUSPEND_TIMEOUT_USEC (500 * 1000)
> #define PHY_RESUME_TIMEOUT_USEC (100 * 1000)
>
> -#ifdef CONFIG_PM_SLEEP
> +#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
Why not #ifdef CONFIG_PM here?
Regards,
Christopher
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
next prev parent reply other threads:[~2014-01-17 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 13:22 Randconfig build failure: screwed dependencies for phy-msm-usb.c Russell King - ARM Linux
2014-01-17 17:26 ` [PATCH] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP Josh Cartwright
2014-01-17 17:46 ` Christopher Covington [this message]
2014-01-17 17:54 ` Kevin Hilman
[not found] ` <87lhyemr3y.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-17 17:58 ` [PATCH v2] " Josh Cartwright
2014-01-17 18:26 ` Josh Cartwright
2014-02-18 16:24 ` Felipe Balbi
[not found] ` <20140218162407.GF9878-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-02-18 16:33 ` Josh Cartwright
2014-02-18 16:42 ` Felipe Balbi
2014-02-18 16:36 ` [PATCH RESEND v3] " Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D96C6F.7090608@codeaurora.org \
--to=cov@codeaurora.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@mm-sol.com \
--cc=joshc@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).