From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C6FC3BED42; Thu, 30 Apr 2026 11:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777546807; cv=none; b=Gvgt4MTLFXbm4aHS2CcN8wzN0Pk3Y1NW4xgjnNCKqgmOFGJil0ZqPl3hG+Nbpd0LhKf4IFWv6mb7crMd/2Oemk+PXcp30ps9I+QVqcwKuLtPbTK9f1KvjUz13WULmyFyX04KHFLZzMVOxMbZkJS054Fbw8o7kC5DedHxV//do1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777546807; c=relaxed/simple; bh=uQlYssfnDnIC6IGTmBlQ3cIPatRkMPMVF+dJm4QH2Os=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bP3Q09OH3iEg/kC3BHniKUxIOFG00cxz9uJpIqRRzninSYmOt6wMAFZMtcwbQiprTaEkvjY844gp6C44xx972vz59YSHpC/ocmE4f0mw+ehd/pFZPXeWQEl0MMPR10l5ZAAOqHoQVX9PapnLUDU9RUJV8X6hcYyeKaeumMedQ+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I2B5ya4E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I2B5ya4E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 461F5C2BCB3; Thu, 30 Apr 2026 11:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777546807; bh=uQlYssfnDnIC6IGTmBlQ3cIPatRkMPMVF+dJm4QH2Os=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=I2B5ya4ESQXzKHqePhmd1Q0ZOXmyEREFizdjz5y4SlUE1PBy65W8XQihxoOXhVz9w Nqv9qHfsNVPb+fGrLkbBgGiJgKzOs9xP9iAwlVQRQMjrdSWD8xnr+Qj1cGMrboysPP vHhZ4PsRtnivXJCRgBZ1gEVuv5Mo4yjrq0c+JMxff9kkN87u2BrTv6osLXYBj8scYe crOEV/C/Gf/hQWpBb+VGgpRJBCLQ+gzZOguf+wfnuaGOgFMz+8hTAw/OncE33le6Jb yfLJ4AELw13cgjMTWwGTqVjdsACs/jSSaVsDL4ky3dlhJ8R3RTzTqGYLEIJty8i+31 HlXc+pinrp2tQ== Message-ID: <5337c2c4-8f04-4185-9d09-130d9e99d147@kernel.org> Date: Thu, 30 Apr 2026 13:00:01 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/13] dt-bindings: clock: qcom,sm8550-dispcc: Add display CESTA support on SM8750 To: Jagadeesh Kona Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Neil Armstrong , Lee Jones , Ajit Pandey , Imran Shaik , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Maulik Shah , Taniya Das References: <20260420-cesta-sm870-dispcc-v1-0-eb27d845df9c@oss.qualcomm.com> <20260420-cesta-sm870-dispcc-v1-2-eb27d845df9c@oss.qualcomm.com> <20260422-savvy-wolverine-of-chivalry-9ae6fc@quoll> <3ea2c4a2-4a1b-4062-b332-9d5d0a53379b@kernel.org> <94a49f16-2e1f-4d32-9d4c-483d56fd2731@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <94a49f16-2e1f-4d32-9d4c-483d56fd2731@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/04/2026 19:25, Jagadeesh Kona wrote: > > > On 4/24/2026 2:39 PM, Krzysztof Kozlowski wrote: >> On 22/04/2026 09:41, Krzysztof Kozlowski wrote: >>> On Mon, Apr 20, 2026 at 09:58:55PM +0530, Jagadeesh Kona wrote: >>>> On SM8750, a subset of DISPCC clocks is controlled by the display CESTA >>>> (Client State Aggregator) hardware. These clocks can be scaled to the >>>> desired frequency by sending votes to the display CRM(CESTA Resource >>>> manager) instead of programming DISPCC registers directly. >>> >>> This looks like completely new, vendor clock API, so no. >>> >>> Resource voting or clock scaling is nothing new and you do not get a >>> vendor phandle to do it. That's like basic upstreaming 101: we do not >>> want another vendor re-implementation of common or typical solutions. >> >> I'll provide a bit more context, what I am looking for: >> Are CESTA and CRMC truly separate blocks? Do they have their own >> resources or maybe something is shared with clock controller, e.g. parts >> of address space? >> > > Thanks Krzysztof for your review > > CRMC is sub-block within the CESTA block. CRMC block contains the clocks frequency lookup tables > information for CESTA controlled RCGs, which clock driver needs to read and populate the RCG's > frequency tables. DISPCC block is outside of CESTA block, so CRMC block is mapped as syscon device > and is used in DISPCC node only to read & populate the CESTA controlled RCGs frequency lookup tables. > The actual clock scaling is done later by converting the frequency into a perf level & sending it > to CESTA HW via CRM APIs. Perf levels should use proper bindings and Linux abstractions, not custom APIs. But what's more important, I don't get the hardware here - clocks are fully within clock controller (DISPCC), but somehow their interface is exposed to CESTA as well, yet CESTA is not a consumer or provider of these clocks. Usually the provider of some resource is in control of that resource, e.g. clock gates or dividers. If some other block (not provider) controls the resource, does that mean that other block is basically part of the provider? Well, you claim not, but how otherwise does it work? > >> If they manage clocks, they should receive some of the clocks as inputs, >> because I don't imagine a block which gates clock somewhere else, to >> which it has no access (IOW, that gate to manage clock is part of the >> clock). Or maybe it's some shadow registers? Or display clock controller >> does not have direct clock access in the first place? Heh, I basically repeated myself here... but your answer here: >> > > Yes, there are few dispcc clocks required for accessing the display CRM/CRMC register > blocks but those clocks are already kept ON from bootloader and they will stay ON as > long as MMCX rail is voted. So if MMCX is ON, we can access CRM/CRMC blocks. is not really answering the problem. Please figure out how a non-provider block can act as provider on some other provider, without access to any of its resources. Best regards, Krzysztof