From: Saravana Kannan <skannan@codeaurora.org>
To: myungjoo.ham@samsung.com
Cc: 박경민 <kyungmin.park@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] PM / devfreq: Use freq_table for available_frequencies
Date: Mon, 14 Apr 2014 22:16:10 -0700 [thread overview]
Message-ID: <534CC09A.30200@codeaurora.org> (raw)
In-Reply-To: <8568895.444151397525760132.JavaMail.weblogic@epml02>
On 04/14/2014 06:36 PM, 함명주 wrote:
>> MyungJoo/Kyungmin,
>>
>> Bump. Can we accept this patch please?
>>
>> -Saravana
>
> Nack.
>
> Please note that freq_table is also an optional value, which may
> be null.
Ah, I saw that the max_freq would be zero if freq_table was NULL and I
assumed that it can't be NULL. But I see that the max_freq limit is not
applied if it's zero. Thanks for catching it.
> Besides, please be aware that your code is under rcu_read_lock().
Valid point. I was just trying to keep the diff simple. No one's really
going to be catting this file often when performance matters.
>
>
> Cheers,
> MyungJoo.
>
> ps. I'll send a related patch (avoid accessing null but not-an-error
> pointer at other sysfs nodes). Thank you for letting me catch such bugs anyway.
I can go ahead and do this myself if you don't mind.
-Saravana
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-04-15 5:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 1:36 Re: [PATCH] PM / devfreq: Use freq_table for available_frequencies 함명주
2014-04-15 5:16 ` Saravana Kannan [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-15 6:30 함명주
2014-04-15 18:41 ` Saravana Kannan
2014-04-17 0:12 ` Saravana Kannan
2014-04-11 2:54 Saravana Kannan
2014-04-14 20:51 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534CC09A.30200@codeaurora.org \
--to=skannan@codeaurora.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).